Page MenuHomePhabricator

Unable the identify the hook subscriber from deprecated hook error message
Open, LowPublic

Description

[2020-06-24 15:01:32] error.WARNING: [87a502f73677d85117d98fc3] [no req]   ErrorException from line 427 of /srv/mediawiki/workdir/includes/debug/MWDebug.php: PHP Deprecated: Use of NewRevisionFromEditComplete hook (used in onNewRevisionFromEditComplete) was deprecated in MediaWiki 1.35. [Called from MediaWiki\HookContainer\HookContainer::run in /srv/mediawiki/workdir/includes/HookContainer/HookContainer.php at line 131] {"exception":"[object] (ErrorException(code: 0): PHP Deprecated: Use of NewRevisionFromEditComplete hook (used in onNewRevisionFromEditComplete) was deprecated in MediaWiki 1.35. [Called from MediaWiki\\HookContainer\\HookContainer::run in /srv/mediawiki/workdir/includes/HookContainer/HookContainer.php at line 131] at /srv/mediawiki/workdir/includes/debug/MWDebug.php:427)
[stacktrace]
#0 [internal function]: MWExceptionHandler::handleError(16384, 'Use of NewRevis...', '/srv/mediawiki/...', 427, Array)
#1 /srv/mediawiki/workdir/includes/debug/MWDebug.php(427): trigger_error('Use of NewRevis...', 16384)
#2 /srv/mediawiki/workdir/includes/debug/MWDebug.php(331): MWDebug::sendMessage('Use of NewRevis...', 'deprecated', 16384)
#3 /srv/mediawiki/workdir/includes/debug/MWDebug.php(301): MWDebug::sendRawDeprecated('Use of NewRevis...', true, 'MediaWiki\\\\HookC...')
#4 /srv/mediawiki/workdir/includes/debug/MWDebug.php(234): MWDebug::deprecatedMsg('Use of NewRevis...', '1.35', 'MediaWiki', 4)
#5 /srv/mediawiki/workdir/includes/GlobalFunctions.php(1031): MWDebug::deprecated('NewRevisionFrom...', '1.35', 'MediaWiki', 3)
#6 /srv/mediawiki/workdir/includes/HookContainer/HookContainer.php(316): wfDeprecated('NewRevisionFrom...', '1.35', false)
#7 /srv/mediawiki/workdir/includes/HookContainer/HookContainer.php(131): MediaWiki\\HookContainer\\HookContainer->callLegacyHook('NewRevisionFrom...', Array, Array, Array)
#8 /srv/mediawiki/workdir/includes/HookContainer/HookRunner.php(2680): MediaWiki\\HookContainer\\HookContainer->run('NewRevisionFrom...', Array)
#9 /srv/mediawiki/workdir/includes/Storage/PageUpdater.php(1225): MediaWiki\\HookContainer\\HookRunner->onNewRevisionFromEditComplete(Object(WikiPage), Object(Revision), false, Object(User), Array)
#10 /srv/mediawiki/workdir/includes/Storage/PageUpdater.php(796): MediaWiki\\Storage\\PageUpdater->doCreate(Object(CommentStoreComment), Object(User), 65)
#11 /srv/mediawiki/workdir/includes/page/WikiPage.php(1973): MediaWiki\\Storage\\PageUpdater->saveRevision(Object(CommentStoreComment), 65)
#12 /srv/mediawiki/workdir/includes/EditPage.php(2347): WikiPage->doEditContent(Object(WikitextContent), Object(CommentStoreComment), 65, false, Object(User), 'text/x-wiki', Array, 0)
#13 /srv/mediawiki/workdir/includes/EditPage.php(1616): EditPage->internalAttemptSave(Array, false)
#14 /srv/mediawiki/workdir/includes/api/ApiEditPage.php(416): EditPage->attemptSave(Array)
#15 /srv/mediawiki/workdir/includes/api/ApiMain.php(1585): ApiEditPage->execute()
#16 /srv/mediawiki/workdir/includes/api/ApiMain.php(525): ApiMain->executeAction()
#17 /srv/mediawiki/workdir/includes/api/ApiMain.php(496): ApiMain->executeActionWithErrorHandling()
#18 /srv/mediawiki/workdir/api.php(84): ApiMain->execute()
#19 {main}
","exception_id":"87a502f73677d85117d98fc3","exception_url":"[no req]","caught_by":"mwe_handler"} []
[24-Jun-2020 15:01:32 UTC] PHP Deprecated:  Use of NewRevisionFromEditComplete hook (used in onNewRevisionFromEditComplete) was deprecated in MediaWiki 1.35. [Called from MediaWiki\HookContainer\HookContainer::run in /srv/mediawiki/workdir/includes/HookContainer/HookContainer.php at line 131] in /srv/mediawiki/workdir/includes/debug/MWDebug.php on line 427

onNewRevisionFromEditComplete is used in many places. The error message does not give sufficient information to figure out which one.

Event Timeline

DannyS712 subscribed.

Agree that it should be clearer from the error. For this specific case it appears to originate from SemanticMediaWiki, which uses that hook. Looking at all other functions named onNewRevisionFromEditComplete:

  • 2x in core for running it
  • edwardspec / mediawiki-moderation - not installed on translatewiki
  • DataTable2 - not installed
  • FlaggedRevs - runs the hook, rather than handling it
  • SplitPrivateWiki - not installed
  • SemanticMediaWiki installed