Page MenuHomePhabricator

Make signature validation error messaging more clear
Closed, ResolvedPublic

Description

This task is about revising how signature validation error messages are presented [i] so people can more clearly understand:

  • The custom signature they have set cannot be saved in its current state
  • Why the custom signature they have set cannot be saved in its current state
  • What they can do to save a signature

1. Current error message treatment
Screen Shot 2020-06-26 at 4.01.56 PM.png (956×1 px, 236 KB)

Event Timeline

The message in your screenshot is only shown when signature validation is entirely disabled. (Sorry, I haven't enabled it on the Beta Cluster yet, I'll do that soon I just enabled it: https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/608621.)

When it's enabled, there is a different message:

Existing invalid signatureTrying to set an invalid signature
image.png (611×1 px, 92 KB)
image.png (611×1 px, 92 KB)

@ppelberg I think no changes are needed here?

ppelberg claimed this task.

@ppelberg I think no changes are needed here?

Agreed. The experience you posted in T256517#6267841 looks fine to me.