aklapper wrote on 2014-06-18 00:35:57 (UTC)

Installing PHPExcel on the server is already covered by T243, hence I'm going to rephrase the task summary to cover the aspect of explicitly mentioning Excel. Prefering "Export to CSV" as that's the data format (spreadsheets can be saved in many ways).

aklapper wrote on 2014-06-18 00:38:58 (UTC)

...and I don't consider this blocking Day 1. We will all feel bad bad bad when seeing "Excel" mentioned, but hell won't freeze over, it will just get slightly colder.

aklapper wrote on 2014-08-19 14:27:08 (UTC)

Upstreamed, but proposed "Export to Spreadsheet" as by default this functionality offers "Excel2007" format.

aklapper wrote on 2014-08-19 16:56:01 (UTC)

WONTFIXed in upstream with a reasonible explanation: https://secure.phabricator.com/T5908#5

importing issue status

That's T152, not this bug.

I'm 99% certain the format is .xlsx, which is OK (although .ods would have been nicer).

The naming can be overridden in the local config file, but I'd say 'Export to Excel' is pretty clear, and the suggested alternatives are less clear. Maybe 'Export as .xlsx' would work.

...and if you want this to be renamed to 'Export as .xlsx' please reopen and adjust the task summary. Thanks.

This situation is really absurd. Why do we keep showing the button if it doesn't work? If I understand correctly it would take a minute for an admin to change the string to "Export (BROKEN)" or "[ignore this button]".

Additionally, the button doesn't have a specific CSS class, but uses class="grey button", so I can't easily display: none it. Should we file reports upstream to ask descriptive class(es)?

(As actionable compromise titles have not worked, I'm reverting to the original request which best expresses the problem whatever the preferred solution might be.)

Should we file reports upstream to ask descriptive class(es)?

If you decided to do so you might want to read https://secure.phabricator.com/T4791 first.

Some suggestions:

• While PHPExcel is not installed, we can use "Export (disabled)" to clarify it's not working yet:
  
• Afterwards, we can simply use "Export":

• or, if this is not clear enough, "Export as .xlsx":

For how to add translations, see https://github.com/wikimedia/operations-puppet/blob/a87adae3e33d725260a00b3b8e5e38c701180903/modules/phabricator/data/fixed_settings.yaml#L176

In T257#984531, @Nemo_bis wrote:

Reopening. It's still not acceptable to promote a proprietary software.

Just to confirm, I checked the Microsoft site: Excel is a trademark (of course) and their general guidelines apply. We are currently in infringement of several articles of them, as far as I can see. "Properly identify Microsoft brand products" certainly applies; perhaps "Using appropriate vs. inappropriate descriptors"; hopefully not "Use Trademark notices"; and currently not " Set Microsoft Trademarks apart from other words or nouns they modify".
[…]

I think your mind was poisoned by WMF Legal's attempt to request that every article mentioning "Wikipedia" had to be approved by WMF :-). Nobody needs to suffix (registered) trademarks with a symbol, and you certainly don't need to comply with arbitrary rules of the trademark owner. You just need to not name your product in a similar way (i. e. distribute a programm called "Ecxel"). If a function exports data to Excel, it's perfectly fine to label it "Export to Excel".

But I agree that this can sound like an endorsement ("you need Excel to process the exported data"), and if possible, I think this should be avoided.

In T257#984606, @valhallasw wrote:

• While PHPExcel is not installed, we can use "Export (disabled)" to clarify it's not working yet:
  
• Afterwards, we can simply use "Export":

Works for me.

Change 189327 had a related patch set uploaded (by Merlijn van Deen):
Change 'Export to Excel' to 'Export (disabled)'

https://gerrit.wikimedia.org/r/189327

Patch-For-Review

Change 189327 merged by Dzahn:
Change 'Export to Excel' to 'Export (disabled)'

https://gerrit.wikimedia.org/r/189327

It now says "(disabled)" to clarify that. I merged the change above.

In T257#3253, @flimport wrote:

aklapper wrote on 2014-06-18 00:35:57 (UTC)

Installing PHPExcel on the server is already covered by T243

^ wrong ticket number, that's something else

In T257#1025895, @Dzahn wrote:

In T257#3253, @flimport wrote:

aklapper wrote on 2014-06-18 00:35:57 (UTC)

Installing PHPExcel on the server is already covered by T243

^ wrong ticket number, that's something else

Yeah, that's T152. This is due to the ticket number mixup after going from phab-01.wmflabs.o -> phabricator.wm.o

thanks, valhallasw. note to self: andre__ told me how to check for the new number of old tickets imported from fab labs. use prefix "fl" in the reference field in advanced search