Page MenuHomePhabricator

QuickSurveys description should be optional
Closed, ResolvedPublic2 Estimated Story Points

Description

Various surveys have been run with blank messages for the description. This has resulted in confusion on wikis, understandably resulting in editors deleting these blank messages.

The surveys should be more lenient and this field should be made optional to avoid everyone having to work around the problem.

AC

  • When I define a survey without a description, no description element should be rendered by the survey

Notes

QA steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_mention_test_0.6269898762366121?quicksurvey=internal%20example%20survey

Survey should have a question, but no description.

QA Results - Beta

ACStatusDetails
1T257695#7160000

QA Results - Prod

ACStatusDetails
1Cannot be QAd in Prod T257695#7161337

Event Timeline

ovasileva triaged this task as Medium priority.Jul 24 2020, 2:26 PM
ovasileva moved this task from Incoming to Triaged but Future on the Readers-Web-Backlog board.
phuedx updated the task description. (Show Details)
phuedx added a subscriber: phuedx.

Change 697609 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/QuickSurveys@master] view: Optionally render description placeholder

https://gerrit.wikimedia.org/r/697609

Change 697609 merged by jenkins-bot:

[mediawiki/extensions/QuickSurveys@master] view: Optionally render description placeholder

https://gerrit.wikimedia.org/r/697609

@Jdlrobson In order to create a survey, according to this, I need to have permissions and be able to access Special:Surveys in beta. I couldn't find that page but I'm not sure if it is related to permissions as well.

Jdlrobson added subscribers: ovasileva, Edtadros.

@ovasileva patchdemo doesn't support QuickSurveys so to test this we'd need to enable a survey on the beta cluster. Do we want to do this now, or as part of a future deploy of a survey and skip QA this time round?

@ovasileva patchdemo doesn't support QuickSurveys so to test this we'd need to enable a survey on the beta cluster. Do we want to do this now, or as part of a future deploy of a survey and skip QA this time round?

Would it be a difficult to set up on the beta cluster? If not, I'd say let's do it just so we know we have this QAd and ready to go before future surveys

I'll set one up but will need help getting it deployed..

I'll set one up but will need help getting it deployed..

Happy to sync it :)

Change 699037 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Drop description on beta labs test survey

https://gerrit.wikimedia.org/r/699037

Change 699037 merged by jenkins-bot:

[operations/mediawiki-config@master] Drop description on beta labs test survey

https://gerrit.wikimedia.org/r/699037

phuedx moved this task from Doing to QA on the Readers-Web-Backlog (Kanbanana-FY-2020-21) board.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: NA

Test Artifact(s):

QA Steps

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Selenium_Echo_mention_test_0.6269898762366121?quicksurvey=internal%20example%20survey

AC1: Survey should have a question, but no description.

Screen Shot 2021-06-16 at 2.25.38 PM.png (795×1 px, 125 KB)