At least in that WMF world that some of us are in, "Operations" internally has shifted to some quite different meaning.
Plus desc on https://phabricator.wikimedia.org/tag/operations/ talks about the "SRE team" anyway.
At least in that WMF world that some of us are in, "Operations" internally has shifted to some quite different meaning.
Plus desc on https://phabricator.wikimedia.org/tag/operations/ talks about the "SRE team" anyway.
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | Aklapper | T258305 Rename #Operations Phab project to #SRE | |||
Resolved | Aklapper | T271405 Adapt IRC notifications for #wikimedia-operations to reflect Operations->SRE rename in Phabricator |
Please make sure to update Wikibugs configuration when renaming Phabricator projects.
@Legoktm: Where to find Wikibugs configuration documentation to find out which file to edit and why? I see https://www.mediawiki.org/wiki/Wikibugs talking about IRC channels but don't see Phab project tags?
https://gerrit.wikimedia.org/r/plugins/gitiles/labs/tools/wikibugs2/%2B/master/channels.yaml
Each IRC channels maps to the projects they want to if a project gets renamed then the channels that track it won't anymore and need their config updating.
I do see your point in the documentation not being the most clear.
Thanks! I'm a bit surprised wikibugs relies on primary tags (which can change at any time) instead of project PHIDs (which are static) but maybe that's T123417?
Change 654809 had a related patch set uploaded (by Aklapper; owner: Aklapper):
[labs/tools/wikibugs2@master] Update name of SRE project in Phab
I'm not entierly sure. Probably best to leave a comment there. It makes sense for readability to have the project names in the config there and looking at it some of it parses what looks like some form of regex.
Change 654810 had a related patch set uploaded (by Aklapper; owner: Aklapper):
[operations/software/klaxon@master] Replace Operations with SRE; link to Phabricator user account help
@Aklapper can I ask why this change was made without any acknowledgement by the SRE team and without any advance notice?
It has broke also another piece of automation that I'm aware of modules/icinga/files/raid_handler.py in the puppet repo. I'm sending a patch now.
Change 654812 had a related patch set uploaded (by Volans; owner: Volans):
[operations/puppet@production] raid handler: fix renamed Phabricator's tag
Change 654812 merged by Volans:
[operations/puppet@production] raid handler: fix renamed Phabricator's tag
Sorry - after half a year without reaction/followup on this ticket, I decided to reduce the public naming confusion a bit. But I should have pinged again, indeed. :-/
It has broke also another piece of automation that I'm aware of modules/icinga/files/raid_handler.py in the puppet repo. I'm sending a patch now.
That sounds error-prone (as unfortunately shown by my edit) - a good number of folks can rename projects (and until a few months ago, literally anyone could).
You may want to hardcode the static Phab project PHID of the SRE tag (PHID-PROJ-5hj6ygnanfu23mmnlvmd) instead, if feasible.
@Aklapper is there any upstream documentation that guarantee that the PHID will not change in any future upgrade with associated schema changes?
Change 654810 merged by jenkins-bot:
[operations/software/klaxon@master] Replace Operations with SRE; link to Phabricator user account help
@Volans: It hasn't changed in >6y (which I can't say about project names) and if it ever changed I'd expect that to be in relnotes as it would break many more things.
wikibugs is supposed to be self-service (as much as possible) and accessible...requiring users to look up project PHIDs and figure all that out really goes against that. Also, this is documented at https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#Renaming_projects
In theory, it's writing ["that project tag"] into the names field on https://phabricator.wikimedia.org/conduit/method/project.query/ and then taking the phid value. But I understand the tradeoff here between "self-service, user-readable" vs "less error-prone".