Page MenuHomePhabricator

Watchlist Expiry: Add half star for Timeless skin
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

As a Watchlist Expiry user, I want the Timeless skin to show the half star when a page is being watched temporarily, so I can easily determine the watch status of a page by viewing the star.

Background

Currently, the Timeless skin only has the "full" watchlist star.

I am guessing we need to do the same thing we did for Vector in T248495.

Acceptance Criteria
  • Display half star when page is being watched temporarily on Timeless

Screenshots:

star_timeless.png (408×542 px, 39 KB)

Event Timeline

dom_walden renamed this task from Add half star for Timeless skin to Watchlist Expiry: Add half star for Timeless skin.Jul 23 2020, 11:56 AM

@Prtksxna Where would we get the half star for this? Thanks!

ARamirez_WMF set the point value for this task to 2.Aug 20 2020, 11:25 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next (June 3-21) on the Community-Tech board.

Here is the half filled star.

Let me know if you need any other formats or if the alignment is off by a pixel :)

Change 621971 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/skins/Timeless@master] Add half-filled star for exipiring watched pages

https://gerrit.wikimedia.org/r/621971

Change 621971 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Add half-filled star for expiring watched pages

https://gerrit.wikimedia.org/r/621971

Change 622218 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/skins/Timeless@REL1_35] Add half-filled star for expiring watched pages

https://gerrit.wikimedia.org/r/622218

Change 622218 abandoned by Samwilson:
[mediawiki/skins/Timeless@REL1_35] Add half-filled star for expiring watched pages

Reason:
It doesn't look like Timeless uses release branches, so there's no need for this.

https://gerrit.wikimedia.org/r/622218

This looks good. I tested this on https://en.wikipedia.beta.wmflabs.org, and I saw a half star after I watched a page temporarily (see screenshot example below). If I watched a page permanently, the star was fully shaded. For this reason, I'm marking this ticket as Done.

Screen Shot 2020-09-04 at 4.23.46 PM.png (217×352 px, 17 KB)