Page MenuHomePhabricator

Mobile section editing summary erroneously shows the page's first section title in some circumstances
Open, Needs TriagePublic

Description

Steps to reproduce:

  1. In mobile view, select a page section (other than the first section link) and edit that section in wikitext.
    1. Make some changes to the wikitext.
  2. Tap the pen icon and choose "Visual editing" and then go back to wikitext editing via the "Source editing" link in the same menu.
  3. Save the page.

Expacted result: The edit summary should, preferably, show the only section edited, or, considering that the whole page is open for editing after switching back to wikitext editing, no section title at all.
Actual result: The page's first section title is added to the summary.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2020, 8:10 PM
JohanahoJ renamed this task from Mobile section editing summary erroneously shows the page's first section in some circumstances to Mobile section editing summary erroneously shows the page's first section title in some circumstances.Jul 24 2020, 8:21 PM

@JohanahoJ: Hi, which website is this about? Is this about VisualEditor-MediaWiki-Mobile? Asking as currently nobody will see this task (no project tags).

@Aklapper Yes, that may be right, as I haven't been able to reproduce the error without at least a short visit in VisualEditor.

Restricted Application added a project: VisualEditor. · View Herald TranscriptJul 25 2020, 11:37 AM
JTannerWMF added a subscriber: JTannerWMF.

The Editing team will see if we can reproduce this issue.

I can reproduce this, but you need another step between 1 and 2: make some changes to the wikitext. The problem only occurs when you switch modes after making changes, and not if you only make changes after switching modes.

matmarex updated the task description. (Show Details)Jul 29 2020, 9:41 PM

Change 617274 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] Fix wrong section name in edit summary when editing whole page in source mode

https://gerrit.wikimedia.org/r/617274

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jul 29 2020, 10:39 PM

Change 617274 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Fix wrong section name in edit summary when editing whole page in source mode

https://gerrit.wikimedia.org/r/617274

@matmarex are you able to verify the patch is working as expected?

Following the steps outlined in the task description, for me, is producing a blank edit summary rather than an edit summary pre-populated with the name of the section whose "Edit" pencil I originally tapped to open the editor. See: https://youtu.be/4fZ6-7GerRk .

I think that's acceptable: by the last step, you're editing the whole page instead of only that section. Either behavior would be fine, and it isn't really clear to me which is more correct, so I would leave it unchanged.

@ppelberg to resolve this task and to follow any subsequent tasks on how this revision behaves