Page MenuHomePhabricator

ULS component remains in a fixed position as the text input area grows
Open, Needs TriagePublic

Description

Behavior

  1. Open the Reply Tool on Beta [once T255191 is merged]
  2. Type a multi-line comment in either mode (source or visual)
  3. Notice the height of the text input area grows

Actual

  1. ❗️Notice the ULS IME component appears in the middle of the now-larger text input area:

Expected

  1. ✅Notice the ULS IME component remains in the same position such that it appears in the bottom right corner of the now-larger text input area

Done

  • "Expected" behavior is implemented

Event Timeline

There's a technical issue here as the resize is done outside of the IME code, which make it harder to notify the IME that a resize has taken place.

There is a new ResizeObserver API in browsers that makes this possible: https://caniuse.com/#search=ResizeObserver which currently has browser support at ~85% (notably not IE11 & Edge before the Chrome switch). This could be done as a progressive enhancement so the bug will just persist in older browsers.