Page MenuHomePhabricator
Create Task
Maniphest T259233

Add supportive gestures to Wikipedia Preview - "Continue Reading" part
Closed, ResolvedPublic
Actions

Description

Problem

At present, some of the key interactions are only possible when users tap. Specifically: to view more content users need to tap on "Continue Reading". This gets the job done, but we can improve the user experience by allowing a supportive gestures like dragging the card up/down

Solution

  • Introduce drag up gesture to reveal more content of preview, drag down to close it. These two are currently performed by tapping on "Continue Reading" CTA and close icon, respectively
  • To drag up and reveal more content, user should be able to drag up from either the body or header of the card
  • To drag down and close the Wikipedia Preview card, users should only be able to drag down the card header. This is to not interfere with any possible text scrolling
  • The tap gesture should remain unchanged

Notes & references

Related Objects

Event Timeline

SGautam_WMF created this task.Jul 30 2020, 8:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 30 2020, 8:42 AM
• AMuigai moved this task from Backlog to two on the Wikipedia-Preview (Mobile-Prototype) board.Aug 4 2020, 2:14 PM
• AMuigai edited projects, added Inuka-Team (Kanban); removed Inuka-Team.Aug 4 2020, 5:00 PM
• AMuigai triaged this task as Medium priority.Aug 4 2020, 5:10 PM
• Rileych moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Aug 5 2020, 2:04 PM
hueitan claimed this task.Aug 10 2020, 8:58 AM
hueitan moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
hueitan renamed this task from Add supportive gestures to Wikipedia Preview to Add supportive gestures to Wikipedia Preview - More Content part.Aug 12 2020, 9:11 AM
hueitan updated the task description. (Show Details)
hueitan added a comment.Aug 12 2020, 9:13 AM
NOTE: I have moved the gallery swipe event to another ticket T260228: Add supportive gestures to Wikipedia Preview - Gallery part

It shares a similar event, but the element and styling are different. Gallery requires layout changes as the current version only show one image.

hueitan removed hueitan as the assignee of this task.Aug 13 2020, 2:26 PM
hueitan moved this task from Dev to Ready for Dev on the Inuka-Team (Kanban) board.
hueitan subscribed.
eamedina claimed this task.Sep 2 2020, 5:54 PM
eamedina moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.
eamedina renamed this task from Add supportive gestures to Wikipedia Preview - More Content part to Add supportive gestures to Wikipedia Preview - "Continue Reading" part.Sep 8 2020, 7:37 PM
eamedina updated the task description. (Show Details)
eamedina updated the task description. (Show Details)Sep 9 2020, 3:43 AM
eamedina added a comment.Sep 9 2020, 3:48 AM

https://github.com/wikimedia/wikipedia-preview/pull/58

eamedina moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Sep 9 2020, 3:48 AM
hueitan moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Sep 14 2020, 8:16 PM

PR Merged. https://github.com/wikimedia/wikipedia-preview/pull/58

• Jpita subscribed.Sep 15 2020, 3:30 PM
  • this doesn't work with the error card
    image.png (698×422 px, 57 KB)
    image.png (185×537 px, 34 KB)
    once we have the error in the console we can't close the card unless we refresh the page
  • the scroll continues once the card is closed, it should stop
    Large GIF (386x674).gif (674×386 px, 3 MB)
• Jpita moved this task from QA to Dev on the Inuka-Team (Kanban) board.Sep 15 2020, 3:36 PM
eamedina added a comment.Sep 15 2020, 9:53 PM

Thanks Pita, I've addressed these two bugs in this follow up PR: https://github.com/wikimedia/wikipedia-preview/pull/62

eamedina moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Sep 15 2020, 9:54 PM
hueitan moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Sep 16 2020, 6:57 AM

Merged.

• Jpita moved this task from QA to Design sign off on the Inuka-Team (Kanban) board.Sep 16 2020, 8:55 PM

looks good now

SGautam_WMF added a comment.Sep 17 2020, 7:12 AM

Seems to be working fine, moving it for product signoff.

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Sep 17 2020, 7:12 AM
• AMuigai closed this task as Resolved.Sep 17 2020, 1:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits