Page MenuHomePhabricator

Accesskey "," doesn't work when syntax highlighting is toggled on
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT

Description

I often use the accesskey "," (comma) to put the cursor in the editing window when editing. However, this doesn't work when syntax highlighting is toggled on.

Steps to reproduce

  1. Make sure that the accesskey works normally by toggling syntax highlighting off, clicking anywhere outside of the editing area and then pressing Alt+, (it could be Alt+, Ctrl+Alt+,, Ctrl+Shift+, or something else depending on your browser/setup/OS)
  2. Toggle syntax highlighting on
  3. Press outside the editing area
  4. Press Alt+, – it won't put the cursor in the editing area.

Fix

Luckily, the fix, which I've tried in my browsers' inspect mode, is extremely easy: Simply add accesskey="," to the div that has contenteditable="true" (i.e. <div class="CodeMirror-code noime">).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 617715 had a related patch set uploaded (by Jon Harald Søby; owner: Jon Harald Søby):
[mediawiki/extensions/CodeMirror@master] Add accesskey to CodeMirror input field

https://gerrit.wikimedia.org/r/617715

thiemowmde set the point value for this task to 1.
thiemowmde changed the subtype of this task from "Task" to "Bug Report".
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-02-17 board.
thiemowmde added a subscriber: thiemowmde.

Change 617715 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] Add accesskey to CodeMirror input field

https://gerrit.wikimedia.org/r/617715

WMDE-Fisch claimed this task.
WMDE-Fisch moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-02-17 board.