Page MenuHomePhabricator

Numbers spill over behind modal on Donate Monthly button [Other input]
Closed, DeclinedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Open https://en.m.wikipedia.org/w/index.php?title=Wikipedia&banner=B2021_0804_enJP_m_p1_lg_txt_cnt&country=JP
  2. Select any donation amount
  3. Select Visa payment method
  4. When presented with the monthly modal prompt select the link that says "Yes, I’ll donate monthly, but for a different amount"
  5. Enter a very large number in the input (ex: "99999999999999999999999999999999999999999999999999999999999999999999999999999999")
  6. Observe numbers spill over on the donate button and appear behind the modal

image.png (894×1 px, 115 KB)

Actual Results:
Currently in the other monthly amount input, when a very large number is entered, the numbers spill over and appear behind modal (see screenshot above) on the Donate Monthly button

Expected Results:
The Donate Monthly button should use an e+ notation (so the above number would equal $1e+80), to avoid resizing and layout issues. Since our max donation allowed online is $12,000 however, this issue is an edge case that isn't realistic, although still might be worth considering, marking as "Lowest" priority.

Event Timeline

jbolorinos-ctr updated the task description. (Show Details)

John, I added a maxlength tag to the OtherMonthlyAmount input. I set it to five characters. Not sure that's the right number, especially for Japan. Maybe we need a couple more? It definitely stops this problem.

Thanks so much Randy! It looks like the max donation amount on the JP banners is 1344000 JPY, so maybe we should set the max char count to 7 instead?

@CDenes_WMF are there any other currencies we should consider for the max number of chars allowed in the "Other" input?

Thanks for the ping, John! Sounds good RE Japan. Regarding other currencies -- Where could I find the max donation amounts per country?

7 seems fine; since this is just a payments wiki MC issue, we're only set up to run post-payment MC in English/6C right now (otherwise MC is in the banner).

Max donation = the local equivalent of $12,000 USD. CO amounts are probably our longest as far as characters, but we aren't set up to run this in CO or JP, only 6C.

Removing deactivated user account from assignee field.

Declined as an edge case.