train-dev
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Aug 4 2020, 7:25 AM

Description

mediawiki/tools/train-dev lacks CI configuration, we should add some :)

https://gerrit.wikimedia.org/g/mediawiki/tools/train-dev/
https://gerrit.wikimedia.org/r/q/project:mediawiki/tools/train-dev

That seems to require booting a VM, Timo recently crafted a job that relies on QEmu and that might be an inspiration T250808

For shell scripts, we can add the shellcheck linter. SRE is adding it to operations/puppet ( T254480 ) and we could use a generic image/script for CI T148494

Conclusion

Starting with just shellcheck and flake8.

Details

Subject	Repo	Branch	Lines +/-
Initial configuration for mediawiki/tools/train-dev tests	integration/config	master	+4 -0
Zuul: [mediawiki/tools/train-dev] Add initial CI, non-voting tox	integration/config	master	+18 -0
Add ansible-lint to be run via tox	mediawiki/tools/train-dev	master	+24 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		dancy	T259586 Add CI to mediawiki/tools/train-dev
		Open		None	T283724 Tracking task to support running arbitrary Docker images

Event Timeline

hashar created this task.Aug 4 2020, 7:25 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 4 2020, 7:25 AM

Noting here that building train-dev currently needs more than just the VM, but also name lookups to be set up and probably other things.

For CI, this will need to be solved somehow. The easiest would be for train-dev building to only need Qemu.

• LarsWirzenius triaged this task as Medium priority.Aug 13 2020, 1:54 PM

Change 620950 had a related patch set uploaded (by Hashar; owner: Ahmon Dancy):
[mediawiki/tools/train-dev@master] Add ansible-lint to be run via tox

https://gerrit.wikimedia.org/r/620950

gerritbot added a project: Patch-For-Review.Aug 18 2020, 2:10 PM

Change 625964 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Add tox to mediawiki/tools/train-dev

https://gerrit.wikimedia.org/r/625964

I would prefer we NOT add CI for train-dev until we're ready. At the moment building train-dev will download some big files from my personal server, and if CI starts doing that, it's going to cost me too much. We'll want to move those files onto suitable WMF servers.

Point taken about files being downloaded from your personal server. That should not prevent us from adding at least the CI entry point (tox) and have it run some linters in the first place. When the dependencies with your personal server are lifted, surely we can then add some end to end test to ensure everything works fine ;]

dancy mentioned this in T264775: Management of git repos snapshot.Oct 6 2020, 5:05 PM

Change 625964 merged by jenkins-bot:
[integration/config@master] Zuul: [mediawiki/tools/train-dev] Add initial CI, non-voting tox

https://gerrit.wikimedia.org/r/625964

thcipriani edited projects, added Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)); removed Release-Engineering-Team-TODO (2020-07-01 to 2020-09-30 (Q1)).Oct 21 2020, 1:07 AM

dancy mentioned this in T267433: Enable support for nested VMs.Nov 6 2020, 6:40 PM

Change 620950 abandoned by Hashar:
[mediawiki/tools/train-dev@master] Add ansible-lint to be run via tox

Reason:
I am giving up on that one.

https://gerrit.wikimedia.org/r/620950

thcipriani removed a project: Release-Engineering-Team-TODO (2020-10-01 to 2020-12-31 (Q2)).Apr 20 2021, 12:21 AM

thcipriani added a project: Release-Engineering-Team-TODO (2021-04-01 to 2021-06-30 (Q4)).Apr 20 2021, 12:34 AM

thcipriani removed a project: Release-Engineering-Team (CI & Testing services).Apr 20 2021, 1:09 AM

Maintenance_bot removed a project: Patch-For-Review.Apr 20 2021, 1:10 AM