CU 2.0: Cannot add new targets to investigation
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Aug 8 2020, 9:50 AM

Description

What is the problem?

I cannot add a new username or IP to an existing investigation.

(Using "Show all IPs of this user" or "Show all users on this IP".)

It submits the form, but targets is blank.

I think because it gets the username/IP from the data-cuc_user_text/data-cuc_ip fields (resp.), but they don't exist anymore since T259106.

Steps to reproduce problem

Launch a new investigation
Hover over the tool menu and click "Show all IPs of this user" or "Show all users on this IP"

Expected behavior: Page refreshes, the username or IP chosen in step 2 is added to the investigation
Observed behavior: Page refreshes, but investigation stays the same

Environment

Wiki(s): Local vagrant: MediaWiki 1.36.0-alpha (004012c), CheckUser 2.5 (9ec06d4)

Notes

This also affects tool links (e.g. URLs are now like https://www.dnsstuff.com/tools/tracert.ch?ip=, with no IP). Raised as T259967. It does not appear to affect filters.

Details

	Subject	Repo	Branch	Lines +/-
	Always use data-value instead of the previous data-FIELDNAME	mediawiki/extensions/CheckUser	master	+9 -9

Customize query in gerrit

Related Objects

Mentioned In: T259967: CU 2.0: Tool link URLs do not have the correct IP
T259106: CU 2.0: Sticky highlighting does not always persist across pages for IPs
T257891: Rollout Special:Investigate on French wikipedia
Mentioned Here: T251906: Customize the "show all users" message on Special:Investigate Compare results table
rMW1ccdde7880a4: Localisation updates from https://translatewiki.net.
rECHUd9a3619d2e64: Merge "Always use data-value instead of the previous data-FIELDNAME"
T259967: CU 2.0: Tool link URLs do not have the correct IP
T259106: CU 2.0: Sticky highlighting does not always persist across pages for IPs
rECHU9ec06d4de9f1: Merge "Fix table cell highlighting in Special:Investigate"
rMW004012c0041e: Merge "GlobalIdGenerator: Spelling correction in a comment"

Event Timeline

dom_walden created this task.Aug 8 2020, 9:50 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 8 2020, 9:50 AM

dom_walden mentioned this in T257891: Rollout Special:Investigate on French wikipedia.Aug 8 2020, 9:52 AM

dom_walden mentioned this in T259106: CU 2.0: Sticky highlighting does not always persist across pages for IPs.

dom_walden updated the task description. (Show Details)Aug 8 2020, 9:58 AM

dom_walden mentioned this in T259967: CU 2.0: Tool link URLs do not have the correct IP.Aug 8 2020, 11:15 AM

dom_walden updated the task description. (Show Details)

Change 619126 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[mediawiki/extensions/CheckUser@master] Always use data-value instead of the previous data-FIELDNAME

https://gerrit.wikimedia.org/r/619126

gerritbot added a project: Patch-For-Review.Aug 8 2020, 3:41 PM

dbarratt claimed this task.Aug 8 2020, 3:43 PM

dbarratt edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

dbarratt moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Change 619126 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Always use data-value instead of the previous data-FIELDNAME

https://gerrit.wikimedia.org/r/619126

dbarratt moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Aug 10 2020, 12:46 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2020, 1:10 PM

I can successfully add a new IP and user to an investigation. The targets parameter in the POST appears to be correct, data in the Compare table and investigation header is updated.

Filters continue to work as before (e.g. correct exclude-targets in POST). Tested using the filters form and "filter from results" menu item.

In case of regression, I tested a few other things that I think might rely on data-FIELDNAME. This included copying as wikitext, the block form (correct targets are prefilled, filtered targets appear in dropdown, targets correctly filled when going to Special:InvestigateBlock).

Also in case of regression, data-edits and data-all-edits still appear in the HTML and are still used by functionality implemented in T251906. This appears to work as it did before.

Test environment Local vagrant MediaWiki 1.36.0-alpha (1ccdde7), CheckUser 2.5 (d9a3619).

Niharika closed this task as Resolved.Aug 14 2020, 8:23 PM

CU 2.0: Cannot add new targets to investigationClosed, ResolvedPublicBUG REPORTActions