Page MenuHomePhabricator
Create Task
Maniphest T260394

Don't show notifications when logged out
Closed, ResolvedPublic
Actions

Assigned To
CCicalese_WMF
Authored By
apaskulin
Aug 13 2020, 10:23 PM
Tags
Referenced Files
F32270798: Screen Shot 2020-09-11 at 10.35.49 AM.png
Sep 11 2020, 5:36 PM
F32113960: Screen Shot 2020-08-13 at 3.22.51 PM.png
Aug 13 2020, 10:23 PM
Subscribers
Aklapper
apaskulin
CCicalese_WMF
Reedy

Description

Page: All pages

Expected behavior: When logged out, the notification icon does not appear in the navigation.

Observed behavior:

Screen Shot 2020-08-13 at 3.22.51 PM.png (162×824 px, 19 KB)

Details

SubjectRepoBranchLines +/-
Hide notification icon for anonymous users in narrow width.mediawiki/skins/WikimediaApiPortalmaster+3 -1
Don't show notifications when logged out or Echo is not installedmediawiki/skins/WikimediaApiPortalmaster+13 -1
Customize query in gerrit

Related Objects

Event Timeline

apaskulin created this task.Aug 13 2020, 10:23 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 13 2020, 10:23 PM
Reedy added a project: Notifications.Aug 14 2020, 1:40 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptAug 14 2020, 1:40 AM
Reedy subscribed.Aug 14 2020, 1:48 AM

It also displays the notifications icon if Echo is disabled...

apaskulin mentioned this in T256793: API Portal: Design validation for WikimediaApiPortal skin.Aug 17 2020, 10:10 PM
apaskulin triaged this task as High priority.Aug 18 2020, 8:58 PM
apaskulin assigned this task to cicalese.Sep 2 2020, 9:31 PM
apaskulin added a project: Platform Team Workboards (Green).
apaskulin moved this task from Backlog to Ready on the Platform Team Workboards (Green) board.Sep 2 2020, 9:38 PM
• WDoranWMF added a project: Platform Team Sprints Board (Sprint 3).Sep 4 2020, 2:07 PM
gerritbot added a comment.Sep 4 2020, 8:57 PM

Change 624906 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/skins/WikimediaApiPortal@master] Don't show notifications when logged out or Echo is not installed

https://gerrit.wikimedia.org/r/624906

gerritbot added a project: Patch-For-Review.Sep 4 2020, 8:57 PM
CCicalese_WMF claimed this task.Sep 4 2020, 9:06 PM
CCicalese_WMF added a subscriber: cicalese.
CCicalese_WMF edited subscribers, added: CCicalese_WMF; removed: cicalese.
apaskulin moved this task from Ready to Waiting for Review on the Platform Team Workboards (Green) board.Sep 4 2020, 11:29 PM
• Pchelolo moved this task from Waiting for Review to Ready to Deploy on the Platform Team Workboards (Green) board.Sep 9 2020, 5:28 PM
gerritbot added a comment.Sep 9 2020, 5:30 PM

Change 624906 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Don't show notifications when logged out or Echo is not installed

https://gerrit.wikimedia.org/r/624906

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 9 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 9 2020, 6:10 PM
apaskulin closed this task as Resolved.Sep 9 2020, 8:44 PM
apaskulin moved this task from Ready to Deploy to Done on the Platform Team Workboards (Green) board.

Verified on beta. Thanks, Cindy!

apaskulin reopened this task as Open.Sep 11 2020, 5:36 PM
apaskulin moved this task from Done to Doing on the Platform Team Workboards (Green) board.

@CCicalese_WMF I just noticed that this is still appearing in the narrower width. My mistake for not catching this during verification!

Screen Shot 2020-09-11 at 10.35.49 AM.png (326×994 px, 36 KB)

gerritbot added a comment.Sep 11 2020, 7:08 PM

Change 626735 had a related patch set uploaded (by Cicalese; owner: Cicalese):
[mediawiki/skins/WikimediaApiPortal@master] Hide notification icon for anonymous users in narrow width.

https://gerrit.wikimedia.org/r/626735

gerritbot added a project: Patch-For-Review.Sep 11 2020, 7:08 PM
CCicalese_WMF added a comment.Sep 11 2020, 7:08 PM

Oops! I made the change in one place but not the other. The new patch should fix that.

gerritbot added a comment.Sep 14 2020, 3:42 PM

Change 626735 merged by jenkins-bot:
[mediawiki/skins/WikimediaApiPortal@master] Hide notification icon for anonymous users in narrow width.

https://gerrit.wikimedia.org/r/626735

apaskulin closed this task as Resolved.Sep 14 2020, 3:50 PM
apaskulin moved this task from Doing to Done on the Platform Team Workboards (Green) board.

Verified on beta. Thanks!

Maintenance_bot removed a project: Patch-For-Review.Sep 14 2020, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits