Page MenuHomePhabricator
Create Task
Maniphest T261067

Use DI in AbuseFilterHooks
Closed, ResolvedPublic
Actions

Description

The AbuseFilterHooks class should use dependency injection to allow unit testing, as per DI docs.

Details

SubjectRepoBranchLines +/-
Switch filterable actions hooks to the new systemmediawiki/extensions/AbuseFiltermaster+335 -322
Move all "secondary" hooks away from AbuseFilterHooksmediawiki/extensions/AbuseFiltermaster+289 -224
Implement GetAutoPromoteGroupsHookmediawiki/extensions/AbuseFiltermaster+184 -32
Add dedicated classes for more hook handlersmediawiki/extensions/AbuseFiltermaster+270 -244
Migrate change tags hooks to DImediawiki/extensions/AbuseFiltermaster+49 -26
Migrate a few hook handlers to DImediawiki/extensions/AbuseFiltermaster+95 -74
Customize query in gerrit

Related Objects
Search...

Event Timeline

Daimona created this task.Aug 23 2020, 10:05 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 23 2020, 10:05 AM
Daimona moved this task from Backlog to Ideas for overhaul on the User-Daimona board.Aug 23 2020, 10:06 AM
Daimona edited projects, added AbuseFilter (Overhaul-2020); removed User-Daimona, AbuseFilter.Sep 16 2020, 3:13 PM
gerritbot added a comment.Oct 4 2020, 11:46 AM

Change 631966 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Migrate a few hook handlers to DI

https://gerrit.wikimedia.org/r/631966

gerritbot added a project: Patch-For-Review.Oct 4 2020, 11:46 AM
gerritbot added a comment.Oct 13 2020, 8:36 AM

Change 631966 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Migrate a few hook handlers to DI

https://gerrit.wikimedia.org/r/631966

gerritbot added a comment.Oct 13 2020, 9:04 AM

Change 632970 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Add dedicated classes for more hook handlers

https://gerrit.wikimedia.org/r/632970

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 13 2020, 10:00 AM
gerritbot added a comment.Oct 14 2020, 2:34 PM

Change 634033 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Migrate change tags hooks to DI

https://gerrit.wikimedia.org/r/634033

gerritbot added a comment.Oct 21 2020, 6:04 PM

Change 634033 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Migrate change tags hooks to DI

https://gerrit.wikimedia.org/r/634033

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.16; 2020-11-03); removed MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 21 2020, 7:00 PM
gerritbot added a comment.Oct 23 2020, 11:38 AM

Change 632970 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Add dedicated classes for more hook handlers

https://gerrit.wikimedia.org/r/632970

Maintenance_bot removed a project: Patch-For-Review.Oct 23 2020, 12:10 PM
Reedy mentioned this in T266681: MediaWiki installer doesn't create tables for extensions registering updates with new Hook handler.Oct 28 2020, 4:33 PM
gerritbot added a comment.Dec 15 2020, 4:33 PM

Change 649672 had a related patch set uploaded (by Matěj Suchánek; owner: Matěj Suchánek):
[mediawiki/extensions/AbuseFilter@master] Implement GetAutoPromoteGroupsHook

https://gerrit.wikimedia.org/r/649672

gerritbot added a project: Patch-For-Review.Dec 15 2020, 4:34 PM
gerritbot added a comment.Dec 18 2020, 1:41 PM

Change 649672 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Implement GetAutoPromoteGroupsHook

https://gerrit.wikimedia.org/r/649672

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 2021-01-05); removed MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Dec 18 2020, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 18 2020, 2:10 PM
gerritbot added a comment.Feb 1 2021, 4:19 PM

Change 660861 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Move all "secondary" hooks away from AbuseFilterHooks

https://gerrit.wikimedia.org/r/660861

gerritbot added a project: Patch-For-Review.Feb 1 2021, 4:19 PM
matej_suchanek moved this task from Backlog to In progress on the AbuseFilter (Overhaul-2020) board.Feb 5 2021, 12:59 PM
gerritbot added a comment.Feb 6 2021, 6:46 PM

Change 660861 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Move all "secondary" hooks away from AbuseFilterHooks

https://gerrit.wikimedia.org/r/660861

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.30; 2021-02-09); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Feb 6 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 6 2021, 7:10 PM
Daimona added a parent task: T211680: Make SpamBlacklist clearly act prior to AbuseFilter on WMF operational wikis.Aug 14 2021, 1:11 PM
Daimona added a subtask: T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter.Aug 14 2021, 1:17 PM
gerritbot added a comment.Aug 14 2021, 2:03 PM

Change 713046 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/AbuseFilter@master] Switch remaining hooks to the new system

https://gerrit.wikimedia.org/r/713046

gerritbot added a project: Patch-For-Review.Aug 14 2021, 2:03 PM
Daimona claimed this task.Aug 14 2021, 2:04 PM
Daimona removed a subtask: T288885: Wikibase runs the EditFilterMergedContent hook with an extra parameter.Aug 14 2021, 2:07 PM
gerritbot added a comment.Aug 17 2021, 7:48 AM

Change 713046 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Switch filterable actions hooks to the new system

https://gerrit.wikimedia.org/r/713046

Daimona closed this task as Resolved.Aug 17 2021, 11:19 AM
Daimona removed a project: Patch-For-Review.
matej_suchanek awarded a token.Aug 18 2021, 8:01 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits