MediaWiki installer (maintenance/install.php) doesn't create AbuseFilter tables. All other extensions seem to work.
This seems to be a new problem, we noticed it when newly created wikis on https://patchdemo.wmflabs.org/ started showing database exceptions.
Running the MediaWiki updater afterwards (maintenance/update.php) creates the tables and fixes the issue.
Downstream report: https://github.com/MatmaRex/patchdemo/issues/166
Do you know if it ever worked?
rEABFb309c804fca3: Add dedicated classes for more hook handlers seems suspect. Ping T261067: Use DI in AbuseFilterHooks
So the installer has some hacky code to load the schema update hooks defined by extensions without loading the rest of their code: https://github.com/wikimedia/mediawiki/blob/master/includes/installer/Installer.php#L1558
I suspect that needs handling for HookHandlers.
I think there's a problem in core: https://gerrit.wikimedia.org/g/mediawiki/core/+/722b5a07d634dbc08de5fdc6439775db52b89aff/includes/installer/Installer.php#1559
This code seems a huge hack, and probably doesn't work with the new hook system. Haven't tested this theory.
This also affects the WikiLambda extension, which also uses HookHandlers, so that seems a likely thing that's broken, yes.
In the original report at https://github.com/MatmaRex/patchdemo/issues/166 it is said FlaggedRevs is also affected, but FlaggedRevs is not using Hook handler system (extension.json) and so its callback should be working fine in theory because it would be loaded same ways as other extensions (that're not using Hook handler and not affected here)
Change 637076 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Installer: Support Hook handler-defined schema update hooks
Change 638355 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/core@master] Support new style hook registration on install and update
Change 637076 abandoned by Ammarpad:
[mediawiki/core@master] Installer: Support Hook handler-defined schema update hooks
Reason:
superseded by I2c41ece04aed11a176559d4364cea2f3320b9574
Change 638355 merged by jenkins-bot:
[mediawiki/core@master] Support new style hook registration on install and update
I guess this wants backporting too as this functionality won't work there, but the new hooks system is in 1.35..
And as inevitably other backports will potentially happen, plus things like the BlueSpice stuff which is actively worked on in release branches...
Change 639498 had a related patch set uploaded (by Jforrester; owner: Tim Starling):
[mediawiki/core@REL1_35] Support new style hook registration on install and update
Change 639498 merged by jenkins-bot:
[mediawiki/core@REL1_35] Support new style hook registration on install and update
This is fixed by those patches, right? It seems to be fixed for me. Thank you for working on it!