Page MenuHomePhabricator

Vector skin search "Go" button uses fulltext search button tooltip
Closed, ResolvedPublic


The magnifying glass button in the Vector skin search box uses the fulltext search button text ([[:Mediawiki:Tooltip-search-fulltext]]) but it is a go search button. This can be solved in one of the following ways

  1. Change button function to fulltext search to match the tooltip
  2. Change the tooltip to [[Mediawiki:Tooltip-search-go]] to match the search button function
  3. Create a new Vector skin search tooltip, since the searching with a single button works different from searching with two search buttons in Monobook skin
  4. Add a fulltext search button and use the correct tooltips like in Monobook skin

Version: 1.20.x
Severity: normal



Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:59 PM
bzimport set Reference to bz24248.

Changing from enhancement to normal bug. Since the tooltip says it searches for page text, even though the button only search for text if there is no page title match.

Thehelpfulonewiki wrote:

Reassign to default per bug 37789

Now there is a fulltext option in the vector search box (I don't remember if this existed when the bug was reported, but I think not since that was part of my fourth suggested solution). This fulltext option uses its own new message [[MediaWiki:Searchsuggest-containing]]. But the vector magnifying glass still uses the incorrect fulltext search tooltip from monobook skin.

Now the problem seems to be that vector skin uses 'image' as $mode for makeSearchButton(), and in includes/SkinTemplate.php that function assumes wrongly that 'image' mode is always fulltext search.

I think the easiest way to fix this is to create a new message (maybe [[Mediawiki:Tooltip-search-image]]) specifically for this 'image search mode', with the text "Search for this text". Without mentioning if it is searching page titles or page content, since using an image as search button does not really say anything about if the search is "go", "fulltext", or something else completely.

(marking as "easy" since this should not be hard to change.)

Monobook and other skins can have a single 'Go' button with the same behaviour as the search image.

Monobook and other skins can have a single 'Go' button with the same
behaviour as the search image.

Yes. I think this is because the newer image search button is behaving as the older 'Go' button. That is why the image search button should not use the tooltip of the fulltext search.

If image search button is always a 'Go' search, it could use the old 'Go' tooltip ([[Mediawiki:Tooltip-search-go]]: "Go to a page with this exact name if exists"). I am not sure that this is always the case, that is why I suggest creating a new tooltip message when an image is used as button.

Another solution is to make a difference between search modes ('go' or 'fulltext') and button modes (button with text or button with image). And letting the tooltip depend only on the search mode, not what type of button is used.

Change 82100 had a related patch set uploaded by Matmarex:
Rewrite rendering of Vector simple search

Change 82100 merged by jenkins-bot:
Rewrite rendering of Vector simple search