| Pginer-WMF | |
| Sep 17 2020, 4:34 PM |
| F33934611: image.png | |
| Dec 3 2020, 4:18 PM |
| F33934609: image.png | |
| Dec 3 2020, 4:18 PM |
| F32353591: Pick a sentence - MT Options.png | |
| Sep 17 2020, 4:34 PM |
| F32353579: Screenshot 2020-09-17 at 14.38.42.png | |
| Sep 17 2020, 4:34 PM |
As part of the "Pick a sentence" step (T251551) of the Section Translation mobile editor, an option to select alternative MT options is provided.
In the current implementation, the layout needs adjustment. Implementation shows a panel that is not taking the whole screen width. It was intended to be full width, with a grey background and the options should be shown as cards.
| Spec | Implementation |
|---|---|
 |  |
This ticket is a follow-up of T259503: Pick a sentence: Support alternative MT selection
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T243495 [Epic] Support for Section Translation | |||
| Open | None | T251551 Section Translation Editor: Pick a sentence | |||
| Resolved | ngkountas | T263146 Alternative MT selection: adjust layout and style |
Change 640075 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SX Sentence Selector: Fix layout for alternative MT selection
Change 640075 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SX Sentence Selector: Fix layout for alternative MT selection
@Pginer-WMF looks good now or still not the same as the spec?
spec implementation
Looks good in general. The most notable difference is the background that being white makes it hard to distinguish the cards. @ngkountas would it be possible to adjust the background to be Base80 instead? Seems a simple change that can be done as part of the ticket. If it hides some complexity we can create as separate task.
There is another minor difference in the "empty sentence" visual treatment, but we can leave it as is for now and check how well it works to just have the empty space.
Change 645366 had a related patch set uploaded (by Nik Gkountas; owner: Nik Gkountas):
[mediawiki/extensions/ContentTranslation@master] SXTranslationSelector: Nest styles under parent class to increase specificity
@Pginer-WMF looks good now or still not the same as the spec?
spec implementation
This is happening because of CSS rules conflict. Fixed in above patch.
Change 645366 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] SXTranslationSelector: Increase specificity to apply background color
