Page MenuHomePhabricator
Create Task
Maniphest T263302

[betalabs] Homepage-variant A: Error: Module "ext.growthExperiments.SuggestedEditSession" is not loaded
Closed, ResolvedPublic
Actions

Description

  1. As a user with activated SE (and Homepage) log in to betalabs.
  2. Go to Special:Homepage - when the page loads, the Console will display the following error:

    Exception in module-execute in module ext.growthExperiments.Homepage.Mentorship:
exception.trace
Error: Module "ext.growthExperiments.SuggestedEditSession" is not loaded
    at Object.require (load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:20)
    at require (load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:10)
    at attachButton (<anonymous>:209:477)
    at <anonymous>:208:734
    at homepage/ext.growthExperiments.Homepage.Mentorship.js (<anonymous>:208:958)
    at runScript (load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:13)
    at execute (load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:14)
    at doPropagation (load.php?lang=en&modules=startup&only=scripts&raw=1&skin=vector:7)

Details

SubjectRepoBranchLines +/-
Add missing dependency for Mentorship JS modulemediawiki/extensions/GrowthExperimentsmaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Sep 18 2020, 11:11 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2020, 11:11 PM
Etonkovidova updated the task description. (Show Details)Sep 18 2020, 11:12 PM
Tgr added a comment.Sep 19 2020, 1:15 AM

I can't reproduce that (and it seems like a ResourceLoader error, not a GrowthExperiments error, and those are unlikely). Any chance you saw this while visiting beta right when the code was updated (and so you ended up with a mix of old and updated code)?

Tgr added a comment.Sep 19 2020, 1:19 AM

Hm, this seems legitimately possible if the Mentorship module is loaded and SuggestedEditSession isn't. Maybe it comes down to timing of the various RL requests whether that happens or not.

gerritbot added a comment.Sep 19 2020, 1:22 AM

Change 628468 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Add missing dependency for Mentorship JS module

https://gerrit.wikimedia.org/r/628468

gerritbot added a project: Patch-For-Review.Sep 19 2020, 1:22 AM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Sep 19 2020, 1:24 AM
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr added a comment.Sep 19 2020, 1:30 AM

This was caused by rEGREbe3d31deafb9: Limit Suggested Edits enabled checks to main and talk namespaces (so not in production yet).

Tgr claimed this task.Sep 19 2020, 1:30 AM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Sep 19 2020, 7:59 AM
gerritbot added a comment.Sep 19 2020, 8:09 AM

Change 628468 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Add missing dependency for Mentorship JS module

https://gerrit.wikimedia.org/r/628468

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2020, 8:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 19 2020, 9:00 AM
Etonkovidova updated the task description. (Show Details)Sep 22 2020, 11:45 PM
Etonkovidova added a comment.Sep 22 2020, 11:49 PM
In T263302#6475978, @Tgr wrote:

I can't reproduce that (and it seems like a ResourceLoader error, not a GrowthExperiments error, and those are unlikely). Any chance you saw this while visiting beta right when the code was updated (and so you ended up with a mix of old and updated code)?

Yes, it was not reliably reproduced from the beginning. I don't see the errors anymore in betalabs; will keep an eye on it in production - then close the ticket.

Etonkovidova closed this task as Invalid.Sep 25 2020, 12:45 AM

Checked in cswiki wmf.10 - it seems that the issue was caused some specific setups in testing env (betalabs) - closing as Invalid.

Tgr changed the task status from Invalid to Resolved.Sep 25 2020, 3:49 AM

I'll call this resolved, since whether or not the missing dependency error could be triggered under normal circumstances, it was incorrect, and it's fixed now.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL