Wikibase EntityDataRequestHandlerTest::testCacheHeaderIsSetWithRevision fails on Travis CI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	WMDE-leszek
	Sep 22 2020, 7:21 AM

Project Tags

Referenced Files

None

Subscribers

Addshore

Aklapper

hoo

Lucas_Werkmeister_WMDE

• Pablo-WMDE

WMDE-leszek

Description

EntityDataRequestHandlerTest::testCacheHeaderIsSetWithRevision seems to fail consistently on Travis CI build.

Example failed test output

There was 1 failure:

1) Wikibase\Repo\Tests\LinkedData\EntityDataRequestHandlerTest::testCacheHeaderIsSetWithRevision

Failed asserting that 'private, no-cache, s-maxage=0' contains "public".

/home/travis/build/wikimedia/phase3/extensions/Wikibase/repo/tests/phpunit/includes/LinkedData/EntityDataRequestHandlerTest.php:376
/home/travis/build/wikimedia/phase3/tests/phpunit/MediaWikiIntegrationTestCase.php:437
/home/travis/build/wikimedia/phase3/maintenance/doMaintenance.php:107

This has started with https://travis-ci.org/github/wikimedia/mediawiki-extensions-Wikibase/builds/729185727 triggered by merging https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/621757

Possibly relevant, possibly not, the failed tests happen in environments where wiki language is not English.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	Fix EntityDataRequestHandlerTest for non-English wikis	Lucas Werkmeister (WMDE)	mediawiki/extensions/Wikibase	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned In: T260349: Wikibase does not purge cached Special:EntityData URLs when revisions or entities are deleted

Event Timeline

WMDE-leszek created this task.Sep 22 2020, 7:21 AM

Herald added a project: Wikidata. · View Herald TranscriptSep 22 2020, 7:21 AM

Herald added a subscriber: Aklapper. · View Herald Transcript

Possibly relevant, possibly not, the failed tests happen in environments where wiki language is not English.

Oh yeah, there might be some confusion about whether the Special:EntityData name is localized or not. I think in non-test code we want it not to be localized, because both the query service updater and the JS UI will always use the English name – but it’s possible that the tests are localizing it.

• Pablo-WMDE mentioned this in T260349: Wikibase does not purge cached Special:EntityData URLs when revisions or entities are deleted.Sep 22 2020, 9:41 AM

Lucas_Werkmeister_WMDE claimed this task.Sep 22 2020, 10:00 AM

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Change 629075 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix EntityDataRequestHandlerTest for non-English wikis

https://gerrit.wikimedia.org/r/629075

gerritbot added a project: Patch-For-Review.Sep 22 2020, 10:00 AM

Change 629075 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix EntityDataRequestHandlerTest for non-English wikis

https://gerrit.wikimedia.org/r/629075

Lucas_Werkmeister_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 22 2020, 4:11 PM

https://travis-ci.org/github/wikimedia/mediawiki-extensions-Wikibase/builds/729361628 is all green.

Thank you!

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 22 2020, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2020, 5:10 PM

Lucas_Werkmeister_WMDE moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Sep 22 2020, 5:33 PM