DraftNotificationPresentationModel.php: Call to a member function getText() on null
Closed, ResolvedPublic
Actions

Description

Error from line 61 of /srv/mediawiki/php-1.36.0-wmf.10/extensions/ContentTranslation/includes/DraftNotificationPresentationModel.php: Call to a member function getText() on null

Logstash: https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-deploy-2020.10.06/mediawiki?id=AXT-1eYD1pGl6xFMpc0T&_g=h@1251ff0

Log

#0 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/formatters/EventPresentationModel.php(539): ContentTranslation\DraftNotificationPresentationModel->getHeaderMessage()
#1 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/formatters/EchoModelFormatter.php(14): EchoEventPresentationModel->jsonSerialize()
#2 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/formatters/EchoEventFormatter.php(72): EchoModelFormatter->formatModel(ContentTranslation\DraftNotificationPresentationModel)
#3 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/DataOutputFormatter.php(189): EchoEventFormatter->format(EchoEvent)
#4 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/DataOutputFormatter.php(149): EchoDataOutputFormatter::formatNotification(EchoEvent, User, string, Language)
#5 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/api/ApiEchoNotifications.php(292): EchoDataOutputFormatter::formatOutput(EchoNotification, string, User, Language)
#6 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/api/ApiEchoNotifications.php(108): ApiEchoNotifications->getPropList(User, array, array, integer, NULL, string, NULL, boolean, boolean)
#7 /srv/mediawiki/php-1.36.0-wmf.10/extensions/Echo/includes/api/ApiEchoNotifications.php(40): ApiEchoNotifications->getLocalNotifications(array)
#8 /srv/mediawiki/php-1.36.0-wmf.10/includes/api/ApiQuery.php(263): ApiEchoNotifications->execute()
#9 /srv/mediawiki/php-1.36.0-wmf.10/includes/api/ApiMain.php(1562): ApiQuery->execute()
#10 /srv/mediawiki/php-1.36.0-wmf.10/includes/api/ApiMain.php(542): ApiMain->executeAction()
#11 /srv/mediawiki/php-1.36.0-wmf.10/includes/api/ApiMain.php(513): ApiMain->executeActionWithErrorHandling()
#12 /srv/mediawiki/php-1.36.0-wmf.10/api.php(90): ApiMain->execute()
#13 /srv/mediawiki/php-1.36.0-wmf.10/api.php(45): wfApiMain()
#14 /srv/mediawiki/w/api.php(3): require(string)
#15 {main}

Impact

A few users are not getting notifications due to likely bad data in the database.

Details

	Subject	Repo	Branch	Lines +/-
	Add validation for invalid titles in notifications	mediawiki/extensions/ContentTranslation	master	+8 -2

Customize query in gerrit

Related Objects

Duplicates Merged Here: T254682: DraftNotificationPresentationModel.php: Call to a member function getText() on null

Event Timeline

KartikMistry created this task.Oct 7 2020, 10:57 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2020, 10:57 AM

KartikMistry merged a task: T254682: DraftNotificationPresentationModel.php: Call to a member function getText() on null.Oct 7 2020, 11:24 AM

Change 632704 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/ContentTranslation@master] Add validation for invalid titles in notifications

https://gerrit.wikimedia.org/r/632704

gerritbot added a project: Patch-For-Review.Oct 7 2020, 11:47 AM

Pginer-WMF triaged this task as Medium priority.Oct 9 2020, 10:04 AM

Pginer-WMF moved this task from Needs Triage to Bugs on the ContentTranslation board.

I think it makes sense to work on this since we are working on reliable notifications.

Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2020-October-December) board.Oct 13 2020, 10:11 AM

Change 632704 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Add validation for invalid titles in notifications

https://gerrit.wikimedia.org/r/632704

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 13 2020, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 13 2020, 12:11 PM

@KartikMistry: let's grep for not a valid title for future purge runs after this is deployed.

Krinkle moved this task from Untriaged to Oct 2020 on the Wikimedia-production-error board.Oct 15 2020, 2:32 AM

In T264855#6538656, @Nikerabbit wrote:

@KartikMistry: let's grep for not a valid title for future purge runs after this is deployed.

Sure. This is available in wmf.15, so next run of script with this change will be on 3rd Nov. I'll check after that.

nikerabbit@mwmaint1002:~$ cat /var/log/mediawiki/mediawiki_job_purge_old_cx_drafts/syslog.log | grep Nov | grep title shows nothing.

Logstash shows some recent errors, but those are likely pre-existing notifications that are being viewed. Not sure if we need to purge those somehow or if they expire on their own.

@KartikMistry I have not seen this error in the logs, have you? If not, I propose we close this for now.

Not seen this recently in logs. Task can be close.

KartikMistry moved this task from Recheck after deployment to Done on the Language-Team (Language-2020-October-December) board.Dec 10 2020, 1:08 PM

Ok, I'm closing this. We should continue grepping for the logs in case it appears in the future.

DraftNotificationPresentationModel.php: Call to a member function getText() on nullClosed, ResolvedPublicActions