Page MenuHomePhabricator
Create Task
Maniphest T264905

Switching mock data in IP Info for live data
Closed, ResolvedPublic5 Estimated Story PointsOct 20 2020
Actions

Description

This task is for us to integrate Maxmind's geoip2 library. The task for security approval on the library is here: T262963: Security Readiness Review For geoip2/geoip2

  1. Add the library to the extension with composer
  2. Add a config variable to where the file is located in the filesystem
  3. Use the freely licensed database for testing
  4. Integrate the library into the extension's InfoManager service
  5. Return the location data through the API from the MaxMind free database

Details

Due Date
Oct 20 2020, 4:00 AM
SubjectRepoBranchLines +/-
Replace mock data with data from GeoLite2 databasemediawiki/extensions/IPInfomaster+327 -44
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT285977 IP Info
 OpenNoneT287647 IP Information accordion on Special:Contribs
 ResolvedOct 20 2020TchandersT264905 Switching mock data in IP Info for live data

Event Timeline

Niharika triaged this task as Medium priority.Oct 7 2020, 3:54 PM
Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2020, 3:54 PM
ARamirez_WMF set the point value for this task to 5.Oct 7 2020, 4:23 PM
dbarratt updated the task description. (Show Details)Oct 7 2020, 4:24 PM
dbarratt removed the point value for this task.
dbarratt set the point value for this task to 5.
Niharika moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.Oct 7 2020, 4:25 PM
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Oct 8 2020, 3:43 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
Tchanders claimed this task.Oct 8 2020, 4:06 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.
ARamirez_WMF set Due Date to Oct 20 2020, 4:00 AM.Oct 8 2020, 10:12 PM
ARamirez_WMF changed the subtype of this task from "Task" to "Deadline".
Tchanders mentioned this in T264837: Figure out which data we can display in IP Info [4H].Oct 14 2020, 7:40 PM
gerritbot added a comment.Oct 14 2020, 8:48 PM

Change 634083 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/IPInfo@master] Replace mock data with data from GeoLite2 database

https://gerrit.wikimedia.org/r/634083

gerritbot added a project: Patch-For-Review.Oct 14 2020, 8:48 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Oct 14 2020, 8:49 PM
Tchanders added subscribers: dom_walden, dbarratt.Oct 14 2020, 9:15 PM

@dbarratt For local reviewing/testing you'll need to do a few things:

  • Get the GeoLite2 databases: https://dev.maxmind.com/geoip/geoip2/geolite2/
  • Put the .mmdb files in the same directory (similar to T264838#6534393)
  • Set $wgIPInfoGeoIP2Path to the database file paths, up to the last common part of the filenames (actually, might want to rethink that to just the path, but that's how the patch currently works...)

Tagging @dom_walden too, but maybe we can set this up on TheGoodPlace so you won't need to test locally.

dbarratt moved this task from Code Review 🔍 to Design Review 🔬 on the Anti-Harassment (The Letter Song) board.Oct 27 2020, 4:02 PM
dbarratt moved this task from Design Review 🔬 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.
gerritbot added a comment.Oct 27 2020, 4:08 PM

Change 634083 merged by jenkins-bot:
[mediawiki/extensions/IPInfo@master] Replace mock data with data from GeoLite2 database

https://gerrit.wikimedia.org/r/634083

Maintenance_bot removed a project: Patch-For-Review.Oct 27 2020, 4:11 PM
Tchanders added a comment.Oct 28 2020, 3:54 PM

@dom_walden This can be tested on thegoodplace (thanks to @dbarratt) - let me know if you have any questions.

dom_walden moved this task from QA/Testing 🐞 to Done: Q2 (2020-2021) ✅ on the Anti-Harassment (The Letter Song) board.Nov 6 2020, 1:55 PM

thegoodplace now shows IP information from MaxMind's GeoLite2.

There are a few errors which are blocking some of the testing of this, e.g. T267398, T267056, T267015.

I haven't tested this on languages other than English, as I don't think we have any translations.

Test Environment: MediaWiki 1.36.0-alpha (4044f5f), CheckUser 2.5 (47b45c2).

dbarratt unsubscribed.Nov 6 2020, 1:56 PM
Tchanders closed this task as Resolved.Dec 3 2020, 1:16 PM
Niharika mentioned this in T287647: IP Information accordion on Special:Contribs.Jul 28 2021, 11:10 PM
Niharika added a parent task: T287647: IP Information accordion on Special:Contribs.Jul 28 2021, 11:13 PM
Niharika moved this task from Backlog to Closed on the IP Info board.Aug 8 2022, 8:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL