Page MenuHomePhabricator
Create Task
Maniphest T265482

On click [ref], jump down to references section
Closed, ResolvedPublic3 Estimated Story Points
Actions

Description

After usability testing confirmed, current behavior feels broken to users. Currently, the preview pops up both on hover and on click - so that if a user hovers and then clicks, nothing happens.

This ticket is to change this behavior. Hover should stay the same, but on click the page should jump down the clicked reference in the bottom (same behavior as if they had clicked the button 'Jump to reference').

Acceptance criteria:

  • Clicking on a reference reverts to its old behavior, jumps down to the footnote in the references section.
  • Clicking on the reference should still send the clickedFootnote event via through the ReferencePreviewsCite topic.
  • Remove the "Jump to reference" link.
  • Hover over a reference should open the popup, same as now.

Details

SubjectRepoBranchLines +/-
Remove reference preview "Jump to reference" linkmediawiki/extensions/Popupsmaster+5 -71
Clicking on a reference should behave normallymediawiki/extensions/Popupsmaster+20 -217
Customize query in gerrit

Related Objects

Event Timeline

ECohen_WMDE created this task.Oct 14 2020, 1:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 14 2020, 1:57 PM
ECohen_WMDE moved this task from Backlog to Ready for pickup on the Reference Previews board.Oct 14 2020, 1:57 PM
Lena_WMDE set the point value for this task to 3.Oct 19 2020, 9:13 AM
Lena_WMDE added a project: WMDE-QWERTY-Sprint-2020-10-21.Oct 21 2020, 8:22 AM
Lena_WMDE moved this task from Ready for pickup to Doing on the Reference Previews board.Oct 21 2020, 8:28 AM
awight claimed this task.Oct 26 2020, 1:11 PM
awight moved this task from Sprint Backlog to Watching on the WMDE-QWERTY-Sprint-2020-10-21 board.
awight moved this task from Watching to Doing on the WMDE-QWERTY-Sprint-2020-10-21 board.
gerritbot added a comment.Oct 26 2020, 2:20 PM

Change 636424 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/Popups@master] Clicking on a reference should behave normally

https://gerrit.wikimedia.org/r/636424

gerritbot added a project: Patch-For-Review.Oct 26 2020, 2:20 PM
awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-10-21 board.Oct 26 2020, 2:21 PM
WMDE-Fisch subscribed.Oct 28 2020, 10:59 AM

@ECohen_WMDE @Lena_WMDE I wonder if this behavior would make the link Jump to reference obsolete? Have you discussed that? It would make the preview popup less clumsy...

awight moved this task from Review to Doing on the WMDE-QWERTY-Sprint-2020-10-21 board.Oct 28 2020, 11:44 AM

I'll work on this a bit more, there's some cleanup and I'd like to restore the click metrics (and giving this a new event ID).

In T265482#6584376, @WMDE-Fisch wrote:

I wonder if this behavior would make the link Jump to reference obsolete?

Underrated suggestion.

awight updated the task description. (Show Details)Oct 29 2020, 8:22 AM
Lena_WMDE added a comment.Oct 29 2020, 8:59 AM

Thanks for raising the question. @ECohen_WMDE and I discussed it and are also in favour of removing the jump to reference link. This also then more closely aligns with the behaviour of Page Previews, which is a plus.

awight updated the task description. (Show Details)Oct 29 2020, 9:42 AM
awight updated the task description. (Show Details)Oct 29 2020, 10:28 AM
awight added a comment.Oct 29 2020, 10:56 AM

The margins are a bit funny, but I'm not planning to fine-tune because we're changing again in T234205: Add cog wheel to the popup to disable ReferencePreviews.

Without scrollbars:

image.png (112×347 px, 8 KB)

With scrollbars:

image.png (386×330 px, 27 KB)

gerritbot added a comment.Oct 29 2020, 11:04 AM

Change 637408 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/Popups@master] Remove reference preview "Jump to reference" link

https://gerrit.wikimedia.org/r/637408

awight moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2020-10-21 board.Oct 29 2020, 11:05 AM
ECohen_WMDE added a comment.Oct 29 2020, 12:16 PM

With scrollbars:

Is there a reason that there is a horizontal scrollbar visible? It should only ever be a vertical one right?

The margins are a bit funny, but I'm not planning to fine-tune because we're changing again in T234205: Add cog wheel to the popup to disable ReferencePreviews.

Also since it's a bit unclear when the cogwheel change will take place/go into effect it might make sense to check the margins now. Can I take a look somewhere? Maybe on beta?

awight added a comment.Oct 29 2020, 12:21 PM
In T265482#6588133, @ECohen_WMDE wrote:

With scrollbars:

Is there a reason that there is a horizontal scrollbar visible? It should only ever be a vertical one right?

Very good point, I carefully crafted some run-on text to not have any whitespaces, for another bug. Otherwise, it would be rare to see the horizontal scrollbar. The "without scrollbars" proportions should apply to the majority of cases.

Can I take a look somewhere? Maybe on beta?

Once the patch is merged it will land on the beta cluster. In theory I could push it to our user testing instance immediately, but IMO it wouldn't make sense to potentially jeopardize those tests over something this minor...

ECohen_WMDE added a comment.Oct 29 2020, 2:44 PM

I just realized this is the perfect use of Patch Demo! I was introduced to it awhile ago so I'll see if I can get it working. Agree doesn't seem worth the hassle to get it onto the test instance.

Otherwise, it would be rare to see the horizontal scrollbar.

Great!

ECohen_WMDE added a comment.Oct 29 2020, 2:51 PM

Screen Shot 2020-10-29 at 15.48.06.png (201×784 px, 31 KB)

nevermind...

gerritbot added a comment.Oct 30 2020, 10:11 AM

Change 636424 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Clicking on a reference should behave normally

https://gerrit.wikimedia.org/r/636424

thiemowmde mentioned this in T266859: More aggressive word wrapping in reference preview popups.Oct 30 2020, 10:29 AM
Lena_WMDE moved this task from Proposed to Currently in sprint on the WMDE-TechWish board.Oct 30 2020, 10:32 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 30 2020, 11:00 AM
gerritbot added a comment.Oct 30 2020, 12:43 PM

Change 637408 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Remove reference preview "Jump to reference" link

https://gerrit.wikimedia.org/r/637408

Maintenance_bot removed a project: Patch-For-Review.Oct 30 2020, 1:10 PM
Andrew-WMDE moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2020-10-21 board.Oct 30 2020, 2:03 PM
awight removed awight as the assignee of this task.Nov 2 2020, 5:03 PM
awight subscribed.
thiemowmde closed this task as Resolved.Nov 3 2020, 12:58 PM
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-10-21 board.Nov 3 2020, 1:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL