Page MenuHomePhabricator

Visual diff displays broken file links improperly
Closed, ResolvedPublic

Description

The issue is about improperly shown filelinks to non-existent files. This was tested on enwiki running 1.36.0-wmf.11 and on a private wiki with REL1_35 code. The results are exactly the same.

Steps to Reproduce:

  • Create a wikipage by making an edit.
  • Make another edit adding a file link to file that does not exist.
  • Compare the two versions using visual diff.

...or just click this link: https://en.wikipedia.org/w/index.php?title=User:Ostrzyciel/test&diff=983703387&oldid=977702941&diffmode=visual

Actual Results:

image.png (1×1 px, 79 KB)

Expected Results:
The image should not appear with a broken thumb. It should probably render just like a broken file link would usually.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 755054 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Broken image: Fix DM HTML for preview to include redlink text

https://gerrit.wikimedia.org/r/755054

Change 755054 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Broken image: Fix DM HTML for preview to include redlink text

https://gerrit.wikimedia.org/r/755054

ppelberg claimed this task.