Page MenuHomePhabricator

AMC: MinervaNeue shows external link icon on the last edited bar
Closed, ResolvedPublic3 Estimated Story Points

Description

See screenshot, that external link icon should not be there. I can reproduce this on MediaWiki.org (1.36-wmf.16) but not on enwiki (still on wmf.14)

QA Results - Beta

ACStatusDetails
1T267464#6638027

QA Results - Prod (Mediawiki, eswiki, enwiki)

ACStatusDetails
1T267464#6674851

Event Timeline

Aklapper renamed this task from MinervaNeue shows extrrnal link icon on the last edited bar to MinervaNeue shows external link icon on the last edited bar.Nov 7 2020, 8:23 AM

cc @ovasileva looks high priority?

yup, let's take a look asap

Change 641264 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Last modified bar should not show external link icon

https://gerrit.wikimedia.org/r/641264

Jdlrobson renamed this task from MinervaNeue shows external link icon on the last edited bar to AMC: MinervaNeue shows external link icon on the last edited bar.Nov 16 2020, 10:10 PM

Note this issue only impacts AMC which links to the ordinary history page via /w/index.php?title=Jane_Grigson&action=history rather than Special:History

I've reopened T176711 the source of this bug and provided a hot fix if we want it https://gerrit.wikimedia.org/r/641264. The hotfix is probably useful just because I've taken the opportunity to do a refactor.

The fix for T259628 should be a better long term solution here.

Refactoring part in patch is useful apart from the source problem. And as it's only one small rule, I've merged it undoubtedly.

Change 641264 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Last modified bar should not show external link icon

https://gerrit.wikimedia.org/r/641264

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhone 11 Pro Max

Test Artifact(s):

QA Steps

✅ AC1: Verify external link does not appear in "Last edited..." history footer

I'm having also the issue, see screenshots:

Spanish Wikipedia


English Wikipedia

Wikimedia Commons

MediaWiki

and in most Wikimedia projects.

The Browser that I'm using is Chrome
Operating system: Android 10
Device: Samsung Galaxy A50

@RodneyAraujo - we have currently fixed the issue, but since our deployment schedule is delayed due to the US holidays, the fix will be available on all wikis on Thursday, December 3

I'm having also the issue, see screenshots:

Spanish Wikipedia


English Wikipedia

Wikimedia Commons

MediaWiki

and in most Wikimedia projects.

The Browser that I'm using is Chrome
Operating system: Android 10
Device: Samsung Galaxy A50

Test Result - Prod

Status: ❌ FAIL
Environment: mediawiki, enwiki
OS: macOS Catalina
Browser: Chrome
Device: MBP
Emulated Device: iPhone 11 Pro Max

Test Artifact(s):

QA Steps

❌ AC1: Verify external link does not appear in "Last edited..." history footer
This appears fixed in Mediawiki...


... and eswiki

...but not fixed in enwiki.

Edtadros added a subscriber: Edtadros.

@Jdlrobson Looks like it is fixed in Mediawiki and eswiki, but not in enwiki. see T267464#6672096

As of today all wikis should be on 1.36.0-wmf.20 so this should be testable now. Can you check again? last week's deploy got delayed.

Test Result - Prod

Status: ✅ PASS
Environment: mediawiki, enwiki, eswiki
OS: macOS Big Sur
Browser: Chrome
Device: MBP
Emulated Device: iPhone 11 Pro Max

Test Artifact(s):

QA Steps

✅ AC1: Verify external link does not appear in "Last edited..." history footer
This is Fixed in Mediawiki and eswiki:
T267464#6672096
and in enwiki.