Page MenuHomePhabricator

Add ability to use ssh-key credentials in pipelinelib pipelines
Closed, ResolvedPublic

Description

In order to do the pre-publish steps for wvui, the docker container needs access to git credentials. Pipelinelib only has the ability to pass text credentials to the container, but we need ssh key credentials.

Acceptance criteria:

  • The credentials id and type can be specified by config.yaml
  • The ssh-key credentials can be passed into the container at run time

Event Timeline

@jeena Just want to make sure we're on the same page about how we're authenticating with gerrit!
The open experimental patch is to authenticate via ssh keys using docker-compose secrets instead of username/pass. But if it's preferred to use username/pass setup in Jenkins instead (or if it will open up opportunities for future projects) I can definitely halt any more experimenting on that patch

@nnikkhoui Sorry, I did not understand that from our conversation. Since there are some concerns about the docker-compose secrets method in this change https://gerrit.wikimedia.org/r/c/wvui/+/640245, I'll wait until we decide on an authentication methods before updating this task.

jeena renamed this task from Add ability to use username-password credentials in pipelinelib pipelines to Add ability to use ssh-key credentials in pipelinelib pipelines.Dec 10 2020, 11:45 PM
jeena updated the task description. (Show Details)