Page MenuHomePhabricator

Reply is placed at the same level, rather than indenting one
Closed, ResolvedPublic



If you scroll down and click the reply to the 13:00, 23 nov 2020 (CET) comment by the IP editor, then you'll see that the indentation is not in the expected location.

Event Timeline

@Whatamidoing-WMF if your're able to, can you please add "Testing instructions" to the task description?

I tested locally and this is already fixed by the patch rEDTOd0ae6c4e445e: Skip end marker "forward" until a block tag is reached (intended for T256033).

The problem here is actually almost the same as T260855#6398286, but the fix for that did not work here because of the <small> tags. Like in that example, there is text after the signature of the first comment (it's the barely-noticeable full stop "." at the end), which was incorrectly treated as if it was a part of the second comment, and that messed with detecting the indentation levels.

Change 643379 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Add tests covering it.wp unsigned comment template

Change 643379 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Add tests covering it.wp unsigned comment template

This comment was removed by Esanders.