Page MenuHomePhabricator
Create Task
Maniphest T268777

"Responsive References" configuration should be exported by a hook
Closed, ResolvedPublic
Actions

Description

(Maybe this will be moot once the Parsoid implementation of the Cite extension moves into the Cite repo.)

Currently Parsoid's SiteConfig::responsiveReferences needs to parse Cite's configuration options ($wgCiteResponsiveReferences) in order to determine whether responsive references are enabled.

Cite should instead export this in a manner that doesn't require Parsoid to know the details of Cite's configuration options. Perhaps a Hook, perhaps a Service, perhaps a static method...

Details

SubjectRepoBranchLines +/-
SiteConfig: Get rid of of Cite-specific methodmediawiki/coreREL1_40+14 -26
SiteConfig: Get rid of of Cite-specific methodmediawiki/coremaster+14 -26
Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0mediawiki/vendormaster+357 -205
Get rid of Cite-specific SiteConfig methodmediawiki/services/parsoidmaster+11 -33
Bump parsoid to 0.17.0-a18mediawiki/vendormaster+648 -273
SiteConfig: Transition away from hardcoded Cite infomediawiki/services/parsoidmaster+58 -4
SiteConfig: Transition away from hardcoded Cite infomediawiki/coremaster+21 -10
Customize query in gerrit

Related Objects

Event Timeline

cscott created this task.Nov 25 2020, 6:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 25 2020, 6:10 PM
ssastry triaged this task as Medium priority.Nov 30 2020, 6:06 PM
ssastry moved this task from Needs Triage to Following Quarter on the Parsoid board.
Izno moved this task from Unsorted backlog to Enhancement backlog on the Cite board.Dec 15 2020, 5:46 PM
Izno moved this task from Enhancement backlog to Parsoid/VE implementation on the Cite board.
cscott mentioned this in T265518: Move Parsoid ServiceWorker.php and extension/src/Config into core.Apr 19 2021, 4:33 PM
Arlolra moved this task from Following Quarter to Tech Debt / Big changes on the Parsoid board.Aug 3 2021, 9:49 PM
ssastry added a project: Parsoid-Read-Views (Phase 1 - DiscussionTools support).Apr 13 2022, 11:37 AM
ssastry moved this task from Backlog to Critical Path (Discussion Tools Only) on the Parsoid-Read-Views (Phase 1 - DiscussionTools support) board.
ssastry removed a project: Parsoid-Read-Views (Phase 1 - DiscussionTools support).Apr 15 2022, 12:57 PM
gerritbot added a comment.Oct 3 2022, 10:59 PM

Change 837754 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] SiteConfig: Transition away from hardcoded Cite info

https://gerrit.wikimedia.org/r/837754

gerritbot added a project: Patch-For-Review.Oct 3 2022, 10:59 PM
gerritbot added a comment.Oct 3 2022, 11:17 PM

Change 837755 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] SiteConfig: Transition away from hardcoded Cite info

https://gerrit.wikimedia.org/r/837755

ssastry claimed this task.Jan 6 2023, 3:08 PM
ssastry added a project: Content-Transform-Team-WIP.
ssastry moved this task from Backlog to Blocked on the Content-Transform-Team-WIP board.
ssastry moved this task from Blocked to In Progress on the Content-Transform-Team-WIP board.Jan 17 2023, 3:01 PM
gerritbot added a comment.Jan 27 2023, 1:04 AM

Change 837754 merged by jenkins-bot:

[mediawiki/core@master] SiteConfig: Transition away from hardcoded Cite info

https://gerrit.wikimedia.org/r/837754

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Jan 27 2023, 2:00 AM
gerritbot added a comment.Feb 20 2023, 11:06 PM

Change 837755 merged by jenkins-bot:

[mediawiki/services/parsoid@master] SiteConfig: Transition away from hardcoded Cite info

https://gerrit.wikimedia.org/r/837755

Maintenance_bot removed a project: Patch-For-Review.Feb 20 2023, 11:10 PM
gerritbot added a comment.Feb 27 2023, 5:39 PM

Change 892515 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a18

https://gerrit.wikimedia.org/r/892515

gerritbot added a project: Patch-For-Review.Feb 27 2023, 5:39 PM
gerritbot added a comment.Feb 27 2023, 6:01 PM

Change 892515 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a18

https://gerrit.wikimedia.org/r/892515

Maintenance_bot removed a project: Patch-For-Review.Feb 27 2023, 6:11 PM
gerritbot added a comment.Mar 7 2023, 5:51 AM

Change 894768 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/services/parsoid@master] Get rid of Cite-specific SiteConfig method

https://gerrit.wikimedia.org/r/894768

gerritbot added a project: Patch-For-Review.Mar 7 2023, 5:51 AM
gerritbot added a comment.Mar 7 2023, 6:17 AM

Change 894769 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@master] SiteConfig: Get rid of of Cite-specific method

https://gerrit.wikimedia.org/r/894769

ssastry moved this task from In Progress to Code Review on the Content-Transform-Team-WIP board.Mar 7 2023, 7:25 PM
gerritbot added a comment.Mar 8 2023, 4:21 PM

Change 894768 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Get rid of Cite-specific SiteConfig method

https://gerrit.wikimedia.org/r/894768

gerritbot added a comment.Mar 10 2023, 6:23 PM

Change 896413 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

gerritbot added a comment.Mar 10 2023, 6:56 PM

Change 896413 merged by jenkins-bot:

[mediawiki/vendor@master] Bump parsoid to 0.17.0-a20 and zest-css to 3.0.0

https://gerrit.wikimedia.org/r/896413

• JMcLeod_WMF moved this task from Code Review to To Deploy on the Content-Transform-Team-WIP board.Mar 13 2023, 3:07 PM
gerritbot added a comment.Mar 15 2023, 3:31 PM

Change 894769 merged by jenkins-bot:

[mediawiki/core@master] SiteConfig: Get rid of of Cite-specific method

https://gerrit.wikimedia.org/r/894769

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.1; 2023-03-20).Mar 15 2023, 4:01 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 15 2023, 4:11 PM
dr0ptp4kt moved this task from To Deploy to To Verify on the Content-Transform-Team-WIP board.Mar 20 2023, 3:14 PM
gerritbot added a comment.Mar 20 2023, 9:31 PM

Change 901277 had a related patch set uploaded (by Subramanya Sastry; author: Subramanya Sastry):

[mediawiki/core@REL1_40] SiteConfig: Get rid of of Cite-specific method

https://gerrit.wikimedia.org/r/901277

gerritbot added a project: Patch-For-Review.Mar 20 2023, 9:31 PM
gerritbot added a comment.Mar 24 2023, 2:20 PM

Change 901277 merged by jenkins-bot:

[mediawiki/core@REL1_40] SiteConfig: Get rid of of Cite-specific method

https://gerrit.wikimedia.org/r/901277

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 2:31 PM
ReleaseTaggerBot edited projects, added MW-1.40-notes; removed MW-1.40-notes (1.40.0-wmf.21; 2023-01-30).Mar 24 2023, 3:01 PM
ssastry closed this task as Resolved.Mar 24 2023, 7:12 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits