CU 2.0: InvestigateBlock does not normalise IP range when leaving notice
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Nov 30 2020, 9:29 AM

Description

What is the problem?

If I use Special:InvestigateBlock to block 192.168.121.180/29 and use the Leave a notice on User/User Talk page functionality, the notice is posted on User/User_talk:192.168.121.180/29.

The normalised version of that IP range is 192.168.121.176/29, so perhaps User/User_talk:192.168.121.176/29 is where the notice should be posted.

Steps to reproduce problem

Go to Special:InvestigateBlock
For target, enter 192.168.121.180/29
Add a Reason
Check Leave a notice on User page and enter a message
Submit

Expected behavior: The message from step 4 is on User:192.168.121.176/29, since this is the range that is actually blocked (e.g. see Special:BlockList).
Observed behavior: The message is on User:192.168.121.180/29.

Environment

Wiki(s): MediaWiki 1.36.0-alpha (ed5d593), CheckUser 2.5 (1309125).

Screenshots (if applicable):

Special:InvestigateBlock:

Notice posted on User:192.168.121.180/29:

specialinvestigateblock_notice_posted.png (130×415 px, 10 KB)

User:192.168.121.176/29 without notice:

Details

	Subject	Repo	Branch	Lines +/-
	Normalize IP range target of block notice	mediawiki/extensions/CheckUser	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned Here: rECHU60b16bbdb90a: SpecialInvestigateBlock: fix checkuser-investigateblock-failure use
rMW8bbd351b6437: Merge "mediawiki.skinning: Remove outdated IE8 support comment"
rECHU1309125ecb1c: Localisation updates from https://translatewiki.net.
rMWed5d5932524f: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Nov 30 2020, 9:29 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2020, 9:29 AM

Change 646629 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/CheckUser@master] Normalize IP range target of block notice

https://gerrit.wikimedia.org/r/646629

gerritbot added a project: Patch-For-Review.Dec 7 2020, 9:34 AM

Tchanders assigned this task to Ammarpad.Dec 22 2020, 6:45 AM

Tchanders updated the task description. (Show Details)

Tchanders moved this task from Untriaged to The Letter Song on the Anti-Harassment board.Dec 22 2020, 6:50 PM

Tchanders edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.

Change 646629 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Normalize IP range target of block notice

https://gerrit.wikimedia.org/r/646629

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 23 2020, 2:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2020, 2:10 AM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Dec 23 2020, 5:25 PM

We now normalise IP ranges when posting to User/User_talk pages. So, blocking 192.168.121.180/29 will leave a notice on User/User_talk:192.168.121.176/29.

This is tested for both IPv4 (thanks @STran) and IPv6.

From what I can tell, the change only affects how we normalise the titles of respective user/user_talk. It does not affect creating blocks in any way.

Just in case, though, I briefly did some regression testing of the blocking functionality of Special:InvestigateBlock. It behaves as it did before.

I notice the IP in the success message (The user 192.168.121.180/29 is now blocked) is not normalised, remains exactly as you entered it. I wonder if this should be normalised as well.

If I block several ranges which all normalise to the same range, the User/User_talk page will have multiple notices written to it. For example, blocking 192.168.121.176/29, 192.168.121.177/29 and 192.168.121.178/29 will cause the same notice to be written three times on User/User_talk:192.168.121.176/29 (if using "Append" or "Prepend"). I am not sure if this is likely to happen in practice, or whether it is a big deal even if it does.

Test environment: Local vagrant MediaWiki 1.36.0-alpha (8bbd351), CheckUser 2.5 (60b16bb).

• Niharika moved this task from Done: Q2 (2020-2021) ✅ to Done: Q3 (2020-2021) on the Anti-Harassment (The Letter Song) board.Jan 6 2021, 7:27 PM

• Niharika closed this task as Resolved.Jan 25 2021, 10:44 PM

	F33928817: specialinvestigateblock_notice_posted.png
	Nov 30 2020, 9:29 AM

	F33928820: specialinvestigateblock_notice_blockmsg.png
	Nov 30 2020, 9:29 AM

	F33928815: specialinvestigateblock_notice.png
	Nov 30 2020, 9:29 AM

CU 2.0: InvestigateBlock does not normalise IP range when leaving noticeClosed, ResolvedPublicBUG REPORTActions