Page MenuHomePhabricator

Minerva selenium test "Wikitext Editor (Makes actual saves) Redirects" failing
Open, HighPublic

Description

The last four builds have failed at "Wikitext Editor (Makes actual saves) Redirects" test:

https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/656/console

Test in question:
https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/947e79de7997b14b9bfe5f071269701c88130534/tests/selenium/specs/editor_wikitext_saving.js#L22

I've checked the video artifact associated with this test [1] and it looks like it is redirecting to the correct page so this might be something wrong with the test rather than a regression.

[1] https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/lastSuccessfulBuild/artifact/log/Wikitext-Editor-(Makes-actual-saves)-Redirects.mp4

Acceptance Criteria

  • Test is skipped and test build goes green
  • Test is fixed and test build stays green

Event Timeline

Jdlrobson raised the priority of this task from Medium to High.Dec 10 2020, 7:23 PM
Jdlrobson added subscribers: Edtadros, Jdlrobson.

cc @Edtadros - would be good for an engineer to pair with you on fixing this one (or skipping it!)

Talked with @Edtadros today and we're going to skip it as a first step

Change 656308 had a related patch set uploaded (by Edward Tadros; owner: Edward Tadros):
[mediawiki/skins/MinervaNeue@master] Selenium: Skip test Wikitext Editor (Makes actual saves)

https://gerrit.wikimedia.org/r/656308

Change 656308 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Selenium: Skip test Wikitext Editor (Makes actual saves)

https://gerrit.wikimedia.org/r/656308

@Edtadros what needs more work on this task?
It looks like the build is passing https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-daily-beta-Minerva/ relatively consistently

@Jdlrobson rather than skipping it I will be making a change to make the wait statement wait for an object vs. a set time.

Change 681705 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/skins/MinervaNeue@master] WIP selenium: Update tests

https://gerrit.wikimedia.org/r/681705

Change 681756 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/skins/MinervaNeue@master] WIP selenium: Page should be creatable

https://gerrit.wikimedia.org/r/681756

Change 681756 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] selenium: Page should be creatable

https://gerrit.wikimedia.org/r/681756

Change 702665 had a related patch set uploaded (by Edward Tadros; author: Edward Tadros):

[mediawiki/skins/MinervaNeue@master] WIP Selenium: redirect

https://gerrit.wikimedia.org/r/702665

Change 702673 had a related patch set uploaded (by Edward Tadros; author: Edward Tadros):

[mediawiki/skins/MinervaNeue@master] selenium: fix failing test "Page should be creatable"

https://gerrit.wikimedia.org/r/702673

Change 702673 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] selenium: Fix failing Jenkins job selenium-daily-beta-Minerva

https://gerrit.wikimedia.org/r/702673

Presumably, we still need to remove the skip statement to call this resolved? Or is the plan to do that in a different ticket?