Page MenuHomePhabricator

Turn off old surveys on the beta cluster running with non-zero coverage
Closed, ResolvedPublic

Description

https://en.wikipedia.beta.wmflabs.org/wiki/Bert

I was asked whether I was interested in participating in a short survey. I said no. The survey said thanks but I couldn't close it. So I refreshed the page. Now it wants to know what's between my legs. I have two options (note the absence of a "close survey" option):

  1. Ignore this eyesore best I can
  2. Lie

So I lied and told the survey my true gender: Bert. The survey says "Thanks for the feedback! We are using it to make Wikipedia even better! All submissions are anonymous. See the privacy policy." but I still can't close it. So despite lying, I still have to ignore this eyesore best I can.

Expected behavior:

  1. Be able to read the article about the magnificent Bert without survey eyesore after telling the survey to buzz off.
  2. Be able to read the article about the magnificent Bert without survey eyesore after telling porkies to the survey.
  3. Be able to read the article about the magnificent Bert without survey eyesore just in general.

What happen instead: my eyes are burning from an unremovable survey.

For the silly survey placement, see T269025.

Event Timeline

Jdlrobson added subscribers: Isaac, Jdlrobson.

I'm a little confused. This is a test wiki and this survey is being shown to test the survey shows. The purpose of the wiki is testing not reading content.
I think the concern around not being able to dismiss a survey is valid, but that's captured in T113644.

@Isaac I assume this survey is still useful for testing and intentionally undismissable? The survey was added in 2019 by 10decea966

If not being used we should disable the survey, but if we are testing it then it seems to be serving its purpose then this task should be declined.
Untagging QuickSurveys as this is site configuration, nothing to do with the extension itself.

I assume this survey is still useful for testing and intentionally undismissable?

@Jdlrobson at this point, the survey can be disabled. Sorry, didn't realize it was still around, but as you point out, it's purely for testing purposes and we are not expecting anyone to respond to it. If you are able to do it quickly, I'd much appreciate you disabling it. If not, let me know, but it may take me a while to get to as I rarely do Gerrit patches.

I'm a little confused. This is a test wiki and this survey is being shown to test the survey shows. The purpose of the wiki is testing not reading content.

I think you're missing the joke, "the magnificent Bert" is not a thing. But I should be able to read an article on beta without anything unplanned getting in the way. If I can't, there's a problem. I understand the survey is no longer needed, so disabling it will resolve this.

@Isaac: out of curiosity, is it supposed to be impossible to dismiss for testing purposes? Has it ever been used in production or are there plans to use it in production?

I can disable it for sure.
While I'm there, there are quite a few surveys on labs. Is Reader-trust-survey-en-v1, reader-demographics-en-pilot, reader-demographics-en also needed? (T225819, T217171, T209882)

@awight is 'wmde-tw-template-survey-prototype-1', wmde-tw-template-survey-prototype-2 (T254322 T255130) still needed on labs?

@AlexisJazz my point is this is a shared test wiki so this is being used for what it's intended. Disabling this survey won't disable the other test surveys.

@Isaac: out of curiosity, is it supposed to be impossible to dismiss for testing purposes? Has it ever been used in production or are there plans to use it in production?

As I've said in my previus comment this is captured in T113644 please follow up there.

@awight is 'wmde-tw-template-survey-prototype-1', wmde-tw-template-survey-prototype-2 (T254322 T255130) still needed on labs?

Thanks, please feel free to remove any of these, or leave them for me to disable.

@AlexisJazz thanks for noticing the mess!

Change 644873 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] Disable QuickSurvey tests

https://gerrit.wikimedia.org/r/644873

Has it ever been used in production or are there plans to use it in production?

@AlexisJazz yes -- see for more details: https://meta.wikimedia.org/wiki/Research:Surveys_on_the_gender_of_editors/Report

is it supposed to be impossible to dismiss for testing purposes?

To @Jdlrobson 's point, constructive feedback on T113644 would be much appreciated so it's easier to push for these changes.

Reader-trust-survey-en-v1, reader-demographics-en-pilot, reader-demographics-en also needed?

All three can be removed - thanks!

@awight I've made the patch but unlikely to be able to deploy this today. It's labs only so if you can take care of the deploy be my guest!

Jdlrobson renamed this task from Gender survey on beta can't be disabled to Turn off old surveys on the beta cluster running with non-zero coverage.Dec 2 2020, 5:05 PM

Change 644873 merged by jenkins-bot:
[operations/mediawiki-config@master] labs: Disable QuickSurvey tests

https://gerrit.wikimedia.org/r/644873

This patch has been merged and should be deployed automatically within 30 minutes

Jdlrobson claimed this task.

Thanks!