Page MenuHomePhabricator

URL Shortener sometimes appears "string" header
Closed, ResolvedPublic

Description

Hello,

Sometimes Special:UrlShortener appears "string" header on the browser (See the image)

Reproduce

  • Happened through Google Chrome; 87.0.4280.66
  • There's no specific things that make it happened, but usually if I click on "Shorten" and the page still opening.

Is that normal to happen?

Event Timeline

alaa created this task.Dec 2 2020, 5:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 2 2020, 5:18 PM

Change 644879 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/UrlShortener@master] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644879

Change 644814 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/UrlShortener@wmf/1.36.0-wmf.20] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644814

Change 644879 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@master] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644879

Change 644814 merged by jenkins-bot:
[mediawiki/extensions/UrlShortener@wmf/1.36.0-wmf.20] Remove var_dump() left by mistake

https://gerrit.wikimedia.org/r/644814

Ladsgroup closed this task as Resolved.Dec 2 2020, 6:03 PM
Ladsgroup claimed this task.

This should never happen again. Re-open if it does. Thanks for reporting! There is a phpcs rule to avoid such cases, we should enable it for most extensions.

Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptDec 2 2020, 6:03 PM
alaa awarded a token.Dec 2 2020, 6:08 PM
Maintenance_bot moved this task from Incoming to Done on the User-Ladsgroup board.Dec 2 2020, 6:15 PM