Page MenuHomePhabricator
Create Task
Maniphest T269807

Skins using BaseTemplate should be able to register via skin options
Closed, ResolvedPublic
Actions

Description

As https://gerrit.wikimedia.org/r/c/mediawiki/skins/BlueSky/+/647359 points out, many skins now only require a single PHP file if using a BaseTemplate

Acceptance criteria

  • The Skin class should not need to define $this->stylename . This should be handled in the constructor and/or inside SkinFactory. It can be derived from name
  • It should be possible to set the name of the PHP class using template option. Note in SkinMustache this is the path to a Mustache file, but here it would be the name of the PHP class.

Details

SubjectRepoBranchLines +/-
Skin: allow specifying template for BaseTemplate skinsmediawiki/coremaster+10 -2
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Dec 9 2020, 9:49 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2020, 9:49 PM
Jdlrobson added subscribers: Ammarpad, Isarra, Mainframe98, ashley.Dec 9 2020, 9:50 PM
Ammarpad added a comment.EditedDec 10 2020, 2:09 PM

I have already suggested this somewhere. Indeed there's no need for a whole class/file to just override two properties

Mainframe98 awarded a token.Dec 10 2020, 2:10 PM
gerritbot added a comment.Dec 18 2020, 9:00 AM

Change 650460 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Skin: allow specifying template for BaseTemplate skins

https://gerrit.wikimedia.org/r/650460

gerritbot added a project: Patch-For-Review.Dec 18 2020, 9:00 AM
Jdlrobson awarded a token.Dec 18 2020, 6:49 PM
gerritbot added a comment.Dec 22 2020, 2:38 AM

Change 650460 merged by jenkins-bot:
[mediawiki/core@master] Skin: allow specifying template for BaseTemplate skins

https://gerrit.wikimedia.org/r/650460

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 22 2020, 3:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 22 2020, 3:10 AM
gerritbot added a comment.Dec 22 2020, 5:35 AM

Change 651312 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Allow specifying styles path in skin manifest

https://gerrit.wikimedia.org/r/651312

gerritbot added a project: Patch-For-Review.Dec 22 2020, 5:35 AM
Jdlrobson closed this task as Resolved.Dec 22 2020, 3:22 PM
Jdlrobson claimed this task.
Jdlrobson updated the task description. (Show Details)

Sweeetttt! we should file some tickets for existing skins that will be simplified by this change.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL