Page MenuHomePhabricator
Create Task
Maniphest T269871

TypeError: userLanguages is null at at wikibase.getUserLanguages.js/</wb.getUserLanguages
Closed, ResolvedPublic
Actions

Description

The script at https://www.wikidata.org/w/index.php?title=User:Bargioni/WikiDesc.js runs the code var user_langs = wb.getUserLanguages(); which appears to trigger the above error message.

Not sure if the gadget is missing dependencies or an issue in the code. 72 instances in last 12hrs.

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.12.10/clienterror/?id=AXZNrLePa1L68BhciPpq

Details

SubjectRepoBranchLines +/-
Don't assume wbUserSpecifiedLanguages is always theremediawiki/extensions/WikibaseREL1_35+1 -1
Don't assume wbUserSpecifiedLanguages is always theremediawiki/extensions/Wikibasemaster+1 -1
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Dec 10 2020, 5:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2020, 5:28 PM
Krinkle moved this task from Untriaged to Dec 2020 on the Wikimedia-production-error board.Dec 15 2020, 7:28 PM
gerritbot added a comment.Dec 16 2020, 9:05 AM

Change 649825 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@master] Don't assume wbUserSpecifiedLanguages is always there

https://gerrit.wikimedia.org/r/649825

gerritbot added a project: Patch-For-Review.Dec 16 2020, 9:05 AM
gerritbot added a comment.Dec 16 2020, 4:17 PM

Change 649825 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Don't assume wbUserSpecifiedLanguages is always there

https://gerrit.wikimedia.org/r/649825

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 16 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 16 2020, 5:10 PM
Michael subscribed.Dec 17 2020, 10:00 AM

I think this patch broke our Travis CI: https://travis-ci.org/github/wikimedia/Wikibase/jobs/750050359

3) LuaStandalone: Wikibase\Client\Tests\Integration\DataAccess\Scribunto\Scribunto_LuaWikibaseLibraryTest::testFormatValue
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'userlang'
+'maxIncludeSize'
/home/travis/build/wikimedia/phase3/extensions/Wikibase/client/tests/phpunit/integration/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTest.php:600
/home/travis/build/wikimedia/phase3/includes/parser/ParserOptions.php:1356
/home/travis/build/wikimedia/phase3/includes/parser/ParserOptions.php:140
/home/travis/build/wikimedia/phase3/includes/parser/ParserOptions.php:357
/home/travis/build/wikimedia/phase3/includes/parser/Parser.php:2856
/home/travis/build/wikimedia/phase3/extensions/Wikibase/client/includes/DataAccess/Scribunto/WikitextPreprocessingSnakFormatter.php:57
/home/travis/build/wikimedia/phase3/extensions/Wikibase/client/includes/DataAccess/Scribunto/SnakSerializationRenderer.php:62
/home/travis/build/wikimedia/phase3/extensions/Wikibase/client/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibrary.php:715
/home/travis/build/wikimedia/phase3/extensions/Wikibase/client/tests/phpunit/integration/includes/DataAccess/Scribunto/Scribunto_LuaWikibaseLibraryTest.php:369
/home/travis/build/wikimedia/phase3/tests/phpunit/MediaWikiIntegrationTestCase.php:437
/home/travis/build/wikimedia/phase3/maintenance/doMaintenance.php:106
Michael added a comment.Dec 17 2020, 10:07 AM

Wait, that can't be. This patch only changes javascript and this test failure is in PHP. Apparently, it just so happened that on the same patch the language handling started to independently fail 🙃

/me keeps looking somewhere else for the cause

Umherirrender added a project: JavaScript.Dec 19 2020, 10:21 PM
Krinkle closed this task as Resolved.Jan 27 2021, 8:58 PM
Krinkle assigned this task to thiemowmde.
gerritbot added a comment.Mar 16 2021, 8:55 AM

Change 672596 had a related patch set uploaded (by Tobias Andersson; owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Wikibase@REL1_35] Don't assume wbUserSpecifiedLanguages is always there

https://gerrit.wikimedia.org/r/672596

gerritbot added a project: Patch-For-Review.Mar 16 2021, 8:55 AM
gerritbot added a comment.Mar 16 2021, 9:08 PM

Change 672596 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@REL1_35] Don't assume wbUserSpecifiedLanguages is always there

https://gerrit.wikimedia.org/r/672596

Maintenance_bot removed a project: Patch-For-Review.Mar 16 2021, 9:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits