Same behaviour was observed in fr:Wikisource with links pointing to the same page (first char=#)
example : [ https://wsexport.wmflabs.org/?lang=fr&page=Les_p%C3%A8res_du_syst%C3%A8me_tao%C3%AFste/Tao-Tei-King&format=epub-3&fonts=]
The links in the summary will take you back to Ws website.

PR: https://github.com/wsexport/tool/pull/322

In T270372#6802384, @Denis_Gagne52 wrote:

Same behaviour was observed in fr:Wikisource with links pointing to the same page (first char=#)
example : [ https://wsexport.wmflabs.org/?lang=fr&page=Les_p%C3%A8res_du_syst%C3%A8me_tao%C3%AFste/Tao-Tei-King&format=epub-3&fonts=]
The links in the summary will take you back to Ws website.

@Denis_Gagne52 the above patch also fixes the issue you are describing

I still find external links on some ebooks.

https://wsexport-test.wmflabs.org/?lang=en&page=The_Variation_of_Animals_and_Plants_under_Domestication%2FXIV&format=epub-3&fonts=:

<sup id="ref_136" class="plainlinks" about="#mwt5" typeof="mw:Transclusion"><a rel="mw:WikiLink" href="https://en.wikisource.org/wiki/The_Variation_of_Animals_and_Plants_under_Domestication/XIV#endnote_136">[136]</a></sup>

https://wsexport-test.wmflabs.org/?lang=fr&page=Les_p%C3%A8res_du_syst%C3%A8me_tao%C3%AFste/Tao-Tei-King&format=epub-3&fonts=:

<a rel="mw:WikiLink" href="c0_Les_peres_du_systeme_taoiste_Tao_Tei_King.xhtml#CH03" title="Les pères du système taoïste/Tao-Tei-King" id="mwEQ">3 <span typeof="mw:Entity" id="mwEg"> </span> —</a> <span typeof="mw:Entity" id="mwEw"> </span>
<a rel="mw:WikiLink" href="https://fr.wikisource.org/wiki/Les_pères_du_système_taoïste/Tao-Tei-King#CH04" id="mwFA">4 <span typeof="mw:Entity" id="mwFQ"> </span> —</a> <span typeof="mw:Entity" id="mwFg"> </span>
<a rel="mw:WikiLink" href="https://fr.wikisource.org/wiki/Les_pères_du_système_taoïste/Tao-Tei-King#CH05" id="mwFw">5 <span typeof="mw:Entity" id="mwGA"> </span> —</a> <span typeof="mw:Entity" id="mwGQ"> </span>

(Note that some of the links for the above ebook are fixed, but others aren't.)

@Samwilson @dmaza How many of these should we expect to be fixed?

All <ref> reference links should be fixed, but there are some works that use manual links to create footnotes and these have not been fixed yet. We don't have a way to identify these, because they're effectively just normal wiki links (as you've pasted above). They used be be identifiable by the fact that they had same-document links, e.g. href="#foo" but Parsoid adds the page name to these, href="Lorem#foo" — we'll add handling for these soon (perhaps in a separate ticket? I'm not sure).

In T270372#6836932, @Samwilson wrote:

All <ref> reference links should be fixed, but there are some works that use manual links to create footnotes and these have not been fixed yet. We don't have a way to identify these, because they're effectively just normal wiki links (as you've pasted above). They used be be identifiable by the fact that they had same-document links, e.g. href="#foo" but Parsoid adds the page name to these, href="Lorem#foo" — we'll add handling for these soon (perhaps in a separate ticket? I'm not sure).

Ah, ok, thanks, I think I understand now.

References that use the conventional <ref> markup are now internal links, e.g.:

• https://wsexport.wmflabs.org/?lang=en&page=Nicene_and_Post-Nicene_Fathers%3A_Series_II%2FVolume_X%2FSelections_from_Letters%2FEpistle_XVII&format=epub-3&fonts=
• https://wsexport.wmflabs.org/?lang=en&page=Dynamical_Theory_of_the_Electric_and_Luminiferous_Medium_III&format=epub-3&fonts=

Books which use the link markup ([[link]]) are a bit harder to predict, and it seems to depend on what the exact link used is. E.g.:

• https://wsexport.wmflabs.org/?lang=en&page=The_Variation_of_Animals_and_Plants_under_Domestication%2FXIV&format=epub-3&fonts=
• https://wsexport.wmflabs.org/?lang=fr&page=Les_p%C3%A8res_du_syst%C3%A8me_tao%C3%AFste/Tao-Tei-King&format=epub-3&fonts=

Test environment WS Export production version 2.3.2.

This was working before and was broken during this project. I don’t understand the difficulty to identify such links. As mentioned earlier, any link built this way [[Les pères du système taoïste/Tao-Tei-King#CHAP1]] will work but not with only #CHAP1 inside the brackets. There are many links built that way. I think the conversion was taken care in this function of BookCleanerEpub.php but the first part does not trap #mylink any more :

/**

• change the internal links

	 */

protected function setLinks( DOMDocument $dom ) {

		$list = $dom->getElementsByTagName( 'a' );
		/** @var DOMElement $node */
		foreach ( $list as $node ) {
			$href = $node->getAttribute( 'href' );
			$title = Util::encodeString( $node->getAttribute( 'title' ) ) . '.xhtml';

>> if ( substr( $href, 0, 1 ) === '#' ) {

@Denis_Gagne52: Thanks for providing this information! I have added it to a new ticket (T275632), which specifically deals with this issue. Feel free to add in any more comments or information into that ticket.