Special:ManageMessageGroups: Button "Submit changes for processing" out of content div in Timeless skin
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Raymond
	Dec 17 2020, 1:02 PM

Description

Since the last update on translatewiki: Special:ManageMessageGroups: Button "Submit changes for processing" out of content div in Timeless skin

Outcome

We broke the display of a button on Special:ManageMessageGroups while updating it's styles, and then we fixed it.

Details

	Subject	Repo	Branch	Lines +/-
	SpecialManageGroups: Use word-wrap for long submit button label	mediawiki/extensions/Translate	master	+3 -1
	Fix layout of the submit button on Special:ManageMessageGroup	mediawiki/extensions/Translate	master	+5 -1

Customize query in gerrit

Related Objects

Mentioned In: T192542: Convert Extension:Translate to OOUI

Event Timeline

Raymond created this task.Dec 17 2020, 1:02 PM

Nikerabbit mentioned this in T192542: Convert Extension:Translate to OOUI.Dec 17 2020, 1:24 PM

...oops.

Why does this need to be so huge and centered in the first place? The goal of OOUI is to have a consistent UI, changing the font size and position is against that goal.

By the way, there are three issues here:

rMW resources/lib/ooui/oojs-ui-core-wikimediaui.css:33 (at d37e8a9e4e7f) setting white-space:nowrap on the <button> (this causes the overflow),
rMW resources/lib/ooui/oojs-ui-core-wikimediaui.css:1335 (at d37e8a9e4e7f) setting margin-right:0 on the <span> parent of the <button> (this makes sure that the <span> wouldn’t be centered even if it didn’t overflow),
and the <button> not being centered within the <span> (so that even if the above two are fixed, the button still starts 10% right of the left side of the content box, and it’s no wider than the button text).

Change 650486 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix layout of the submit button on Special:ManageMessageGroup

https://gerrit.wikimedia.org/r/650486

gerritbot added a project: Patch-For-Review.Dec 20 2020, 2:39 PM

Nikerabbit moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.Dec 23 2020, 1:10 PM

Nikerabbit changed the subtype of this task from "Task" to "Bug Report".

Nikerabbit added a project: Language-Team (Language-2020-October-December).

Nikerabbit moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2020-October-December) board.

Change 650486 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix layout of the submit button on Special:ManageMessageGroup

https://gerrit.wikimedia.org/r/650486

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Dec 23 2020, 2:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 23 2020, 2:10 PM

The patch seems to be incomplete. In case of a longer translation the button text is running out of the box.

Nikerabbit moved this task from Recheck after deployment to Priority Backlog on the Language-Team (Language-2020-October-December) board.Jan 4 2021, 7:29 AM

Pginer-WMF edited projects, added Language-Team (Language-2021-January-March); removed Language-Team (Language-2020-October-December).Jan 4 2021, 10:17 AM

Pginer-WMF moved this task from Quarter Backlog to Priority Backlog on the Language-Team (Language-2021-January-March) board.

abi_ claimed this task.Jan 11 2021, 3:58 AM

abi_ triaged this task as Low priority.

abi_ moved this task from Priority Backlog to In Progress on the Language-Team (Language-2021-January-March) board.

Change 655424 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] SpecialMangeGroups: Use ellipsis for long submit button label

https://gerrit.wikimedia.org/r/655424

gerritbot added a project: Patch-For-Review.Jan 11 2021, 12:43 PM

Thanks for the report Raymond, I've submitted a fix to show ellipsis in-case of overflowing text and additionally reduced the font size as well.

Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2021-January-March) board.Jan 19 2021, 7:40 AM

Change 655424 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] SpecialManageGroups: Use word-wrap for long submit button label

https://gerrit.wikimedia.org/r/655424

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2021, 2:11 PM

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.28; 2021-01-26); removed MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 20 2021, 3:00 PM

Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-January-March) board.Jan 21 2021, 12:15 PM

Works now:

Nikerabbit closed this task as Resolved.Jan 26 2021, 1:33 PM

Nikerabbit updated the task description. (Show Details)

As @Tacsipacsi pointed out above, is there some special reason to make this submit button needed to be such large here? Thanks.

It's always been huge, so we've kept it so as a tradition.

The question is whether it’s a good tradition. I don’t use this special page, so I have no strong opinion on the matter, but it doesn’t seem for me to be a particularly good tradition, as it breaks consistency with both MediaWiki core and other special pages of Translate.

Stang unsubscribed.Oct 12 2022, 10:33 PM

	F34026127: kuva.png
	Jan 26 2021, 1:33 PM

	F33995713: image.png
	Jan 11 2021, 12:52 PM

Special:ManageMessageGroups: Button "Submit changes for processing" out of content div in Timeless skinClosed, ResolvedPublicBUG REPORTActions