Page MenuHomePhabricator

Special:ManageMessageGroups: Button "Submit changes for processing" out of content div in Timeless skin
Closed, ResolvedPublicBUG REPORT

Description

Since the last update on translatewiki: Special:ManageMessageGroups: Button "Submit changes for processing" out of content div in Timeless skin

Outcome

We broke the display of a button on Special:ManageMessageGroups while updating it's styles, and then we fixed it.

Event Timeline

Why does this need to be so huge and centered in the first place? The goal of OOUI is to have a consistent UI, changing the font size and position is against that goal.

By the way, there are three issues here:

Change 650486 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Fix layout of the submit button on Special:ManageMessageGroup

https://gerrit.wikimedia.org/r/650486

Change 650486 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Fix layout of the submit button on Special:ManageMessageGroup

https://gerrit.wikimedia.org/r/650486

The patch seems to be incomplete. In case of a longer translation the button text is running out of the box.

abi_ triaged this task as Low priority.

Change 655424 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] SpecialMangeGroups: Use ellipsis for long submit button label

https://gerrit.wikimedia.org/r/655424

Thanks for the report Raymond, I've submitted a fix to show ellipsis in-case of overflowing text and additionally reduced the font size as well.

Change 655424 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] SpecialManageGroups: Use word-wrap for long submit button label

https://gerrit.wikimedia.org/r/655424

Nikerabbit updated the task description. (Show Details)