Page MenuHomePhabricator
Create Task
Maniphest T270902

Key 'page_time' doesn't exist in table 'logging'
Closed, ResolvedPublic
Actions

Description

Similar to T270769: Wikimedia\Rdbms\DBQueryError: Error 1176: Key 'times' doesn't exist in table 'logging'

Details

SubjectRepoBranchLines +/-
Update index used for logging querymediawiki/extensions/CheckUsermaster+1 -1
Handle Logging index that's being renamedmediawiki/extensions/CheckUsermaster+9 -2
Customize query in gerrit

Related Objects

Event Timeline

Nikerabbit created this task.Dec 29 2020, 8:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2020, 8:54 AM
Nikerabbit triaged this task as High priority.Dec 29 2020, 8:56 AM
Nikerabbit added subscribers: Ladsgroup, Ammarpad.

#7 /srv/mediawiki/workdir/extensions/CheckUser/includes/specials/SpecialCheckUser.php(2033): Wikimedia\\Rdbms\\DBConnRef->selectField('logging', '1', Array, 'SpecialCheckUse...', Array)
#8 /srv/mediawiki/workdir/extensions/CheckUser/includes/specials/SpecialCheckUser.php(1716): SpecialCheckUser::userWasBlocked('...')

DannyS712 added a parent task: T267418: 1.36.0-wmf.25 deployment blockers.Dec 29 2020, 10:04 AM
gerritbot added a comment.Dec 29 2020, 10:08 AM

Change 652253 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/CheckUser@master] Update index used for logging query

https://gerrit.wikimedia.org/r/652253

gerritbot added a project: Patch-For-Review.Dec 29 2020, 10:08 AM
DannyS712 claimed this task.Dec 29 2020, 10:08 AM
DannyS712 raised the priority of this task from High to Unbreak Now!.
DannyS712 subscribed.

Train blocker -> UBN

Restricted Application added a project: User-DannyS712. · View Herald TranscriptDec 29 2020, 10:08 AM
Ladsgroup lowered the priority of this task from Unbreak Now! to High.Dec 29 2020, 10:11 AM

It is not a train blocker, the log index schema changes won't go live any time soon.

taavi removed a parent task: T267418: 1.36.0-wmf.25 deployment blockers.Dec 29 2020, 11:59 AM
taavi subscribed.

Removing parent task per Amir's comment

gerritbot added a comment.Dec 29 2020, 12:54 PM

Change 652400 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/CheckUser@master] Handle Logging index that's being renamed

https://gerrit.wikimedia.org/r/652400

gerritbot added a comment.Jan 1 2021, 1:38 PM

Change 652400 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Handle Logging index that's being renamed

https://gerrit.wikimedia.org/r/652400

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.25; 2021-01-05).Jan 1 2021, 2:00 PM
gerritbot added a comment.Jan 1 2021, 9:46 PM

Change 652253 abandoned by Umherirrender:
[mediawiki/extensions/CheckUser@master] Update index used for logging query

Reason:
Superseeded by I4c3f945c002d50908f1fe65696d325363e5dc6b5

https://gerrit.wikimedia.org/r/652253

Ladsgroup added a comment.Jan 3 2021, 12:22 PM

This is done. right? We can keep it open for removing the temporary bit later or create a new ticket for that. Whatever you prefer.

Nikerabbit added a comment.Jan 3 2021, 1:44 PM

Not sure who you would like to answer, but since no action seems to be required from me, I don't have a preference.

Ammarpad closed this task as Resolved.Jan 3 2021, 2:55 PM
Ammarpad claimed this task.
Ammarpad removed a project: Patch-For-Review.

I believe the logic can be removed as a cleanup even without a task, provided the schema change is live everywhere.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits