Run jobs/tests for Wikibase libraries that are maintained on Github on PHP8 in CI
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

We maintain a variety of libraries on Github that are used in Wikibase, and we would like to start testing our code with PHP 8, as support for this version is on the roadmap for wikidata.org.

Most of these repositories currently use Travis for CI. However, making the change in Travis is not as straightforward (See comment T271109#6739532). In addition, and in accordance with the general direction of ADR 16, we would prefer to add these new tests as GitHub actions.

Scope:

Acceptance criteria:

All WMDE maintained Wikibase related GitHub repositories run PHP tests in PHP 8 in CI

Related Objects

Mentioned Here: T270158: [12h] Decide on the "secondary" CI for Wikibase code repository

Event Timeline

WMDE-leszek created this task.Jan 4 2021, 2:35 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJan 4 2021, 2:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Notes on possible approach.
In T270158#6698112 it was detailed that we can do everything we do in Travis on Github actions with little effort.
Thus one possible approach could be to stop using travis and use Github Actions.
This task should keep an eye on how T270158 develops

WMDE-leszek moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Jan 5 2021, 12:26 PM

Addshore updated the task description. (Show Details)Jan 5 2021, 1:28 PM

WMDE-leszek updated the task description. (Show Details)Jan 5 2021, 2:39 PM

Declining as this is addressing the problem from the wrong end of the stick. Will open a task about testing WMDE repos on PHP 8 instead.

Addshore renamed this task from Wikibase related Travis CI builds cannot run tests in PHP8 environment to Run jobs/tests for Wikibase libraries that are maintained on Github on PHP8 in CI.Jan 12 2021, 12:14 PM

Addshore reopened this task as Open.

Addshore updated the task description. (Show Details)

Notes regarding travis and php8 that were previously in the description:

As demonstrated in e.g. https://github.com/wmde/WikibaseDataModel/pull/836 (failing build example https://travis-ci.com/github/wmde/WikibaseDataModel/jobs/466582412) Travis CI builds for (some) Wikibase-related github codebases fail when trying to run PHP tests in PHP 8 environment with:
The command "phpenv global 8.0" failed and exited with 1 during .

ItamarWMDE updated the task description. (Show Details)Jan 12 2021, 1:14 PM

Addshore updated the task description. (Show Details)Jan 12 2021, 1:15 PM

Adding another now removed comment about running PHP8 on Travis CI (should be of relevance)

https://travis-ci.community/t/php-8-0-missing/10132/28 suggests the issue stems from the fact that PHP 8 is not available in the old/legacy Ubuntu Trusty environments

The WikibaseDataModel pull request is passing now (edit: using Travis CI).

Prio session note:
Noticed that this ticket was not picked up last week, but the ticket that was below it in the prioritization order was picked up.

To add in task breakdown: the list of repositories to take into account so that none is forgotten

I think the repositories would be:

We have a few more Wikibase repositories in the wmde org, but these three are the ones that have PHP versions in their Travis config, as far as I can tell.

darthmon_wmde set the point value for this task to 8.Jan 20 2021, 1:20 PM

darthmon_wmde moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 20 2021, 1:35 PM

darthmon_wmde edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 20 2021, 2:15 PM

noarave updated the task description. (Show Details)Jan 21 2021, 1:09 PM

Lucas_Werkmeister_WMDE claimed this task.Jan 22 2021, 2:32 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)

Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 22 2021, 3:27 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 22 2021, 3:46 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 22 2021, 4:12 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 22 2021, 4:20 PM