t is undefined (from isImageInGallery on KaiOS)
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	SBisson
	Jan 6 2021, 7:59 PM

Description

Error

App version: 1.2.0

message

t is undefined

Impact

Unclear. It is possible it breaks link navigation on article with no images.

Notes

t refers to the galleryItems argument of the isImageInGallery function

It's easy enough to add a guard so the function doesn't break but part of this task is also to identify why galleryItems is null (find an article where it is the case).

Details

Request URL: n/a

Stack Trace

exception.trace

isImageInGallery@app://kaios.wikipedia.org/dist/main.js:1:403957
findVisibleLinks@app://kaios.wikipedia.org/dist/main.js:1:403767
useArticleLinksNavigation/<@app://kaios.wikipedia.org/dist/main.js:1:401332
q@app://kaios.wikipedia.org/dist/main.js:1:314144
hooks_module_/<@app://kaios.wikipedia.org/dist/main.js:1:313995
hooks_module_@app://kaios.wikipedia.org/dist/main.js:1:313927

Event Timeline

SBisson created this task.Jan 6 2021, 7:59 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2021, 7:59 PM

Krinkle renamed this task from t is undefined to t is undefined (from isImageInGallery on KaiOS).Jan 6 2021, 10:31 PM

Krinkle moved this task from Untriaged to Jan 2021 on the Wikimedia-production-error board.

SBisson updated the task description. (Show Details)Jan 11 2021, 1:57 PM

eamedina moved this task from Backlog to Ready for Dev on the Inuka-Team (Kanban) board.Jan 11 2021, 2:18 PM

eamedina claimed this task.Jan 11 2021, 7:04 PM

eamedina moved this task from Ready for Dev to Dev on the Inuka-Team (Kanban) board.

https://github.com/wikimedia/wikipedia-kaios/pull/306

eamedina moved this task from Dev to Code Review on the Inuka-Team (Kanban) board.Jan 13 2021, 8:03 PM

SBisson moved this task from Code Review to QA on the Inuka-Team (Kanban) board.Jan 13 2021, 8:19 PM

• Jpita moved this task from QA to QA WAITING FOR FEEDBACK on the Inuka-Team (Kanban) board.Jan 13 2021, 10:40 PM

waiting for devs help to be able to debug the live code to change variables values

eamedina moved this task from QA WAITING FOR FEEDBACK to Design sign off on the Inuka-Team (Kanban) board.Jan 18 2021, 2:13 PM

SGautam_WMF moved this task from Design sign off to Product sign off on the Inuka-Team (Kanban) board.Jan 19 2021, 9:13 AM

• AMuigai closed this task as Resolved.Jan 19 2021, 12:38 PM

t is undefined (from isImageInGallery on KaiOS)Closed, ResolvedPublicPRODUCTION ERRORActions