[S] [wmf.25] MediaSearch: Audio mid files do not have audio icons
Closed, ResolvedPublic
Actions

Description

Found when checking T258298.

On commons wmf.25 go to Special:MediaSearch
Select Audio tab and select mid as a file format option.
Enter search item(s) - e.g. "Chopin', 'march' ( or just click on the link https://commons.wikimedia.org/wiki/Special:MediaSearch?type=audio&q=waltz). Many search results won't display the icon.

Screen Shot 2021-01-06 at 2.48.45 PM.png (543×866 px, 67 KB)

Note: Seems that the issue is specific to mid format only.

Details

	Subject	Repo	Branch	Lines +/-
	Always display icons for audio/video files	mediawiki/extensions/WikibaseMediaInfo	master	+32 -15

Customize query in gerrit

Related Objects

Mentioned In: T258298: [S] Adding audio and video icons to search result design
Mentioned Here: T258298: [S] Adding audio and video icons to search result design

Event Timeline

Etonkovidova created this task.Jan 6 2021, 10:42 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2021, 10:42 PM

Etonkovidova renamed this task from [wmf.25] MediaSearch: Audio mid files do not audio icons to [wmf.25] MediaSearch: Audio mid files do not have audio icons.Jan 6 2021, 10:49 PM

Etonkovidova added a project: Structured-Data-Backlog.

Etonkovidova updated the task description. (Show Details)

Etonkovidova added subscribers: CBogen, AnneT, • Ramsey-WMF.

CBogen edited projects, added Structured-Data-Backlog (Current Work), SDAW-MediaSearch (MediaSearch-ReleaseCandidate2); removed Structured-Data-Backlog.Jan 6 2021, 10:50 PM

CBogen moved this task from Incoming to Ready for Estimation on the Structured-Data-Backlog (Current Work) board.

Etonkovidova mentioned this in T258298: [S] Adding audio and video icons to search result design.Jan 7 2021, 1:57 AM

CBogen added a comment.Jan 19 2021, 5:27 PM

This comment was removed by CBogen.

CBogen renamed this task from [wmf.25] MediaSearch: Audio mid files do not have audio icons to [S] [wmf.25] MediaSearch: Audio mid files do not have audio icons.Jan 19 2021, 5:28 PM

CBogen moved this task from Ready for Estimation to Ready for Development on the Structured-Data-Backlog (Current Work) board.

It looks like this snippet is wrapped inside a imageinfo[0].duration condition.
Only the actual duration should not show up if we don't know the duration - the icon & mime type (if we know the mime type) should still show up, regardless of whether or not we know the duration.

matthiasmullie claimed this task.Feb 9 2021, 3:56 PM

Change 663186 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Always display icons for audio/video files

https://gerrit.wikimedia.org/r/663186

gerritbot added a project: Patch-For-Review.Feb 10 2021, 12:35 PM

matthiasmullie moved this task from Ready for Development to Code Review on the Structured-Data-Backlog (Current Work) board.Feb 10 2021, 12:37 PM

Change 663186 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Always display icons for audio/video files

https://gerrit.wikimedia.org/r/663186

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 11 2021, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2021, 12:10 AM

AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Feb 11 2021, 1:29 AM

Etonkovidova moved this task from Needs QA to Verify on Production on the Structured-Data-Backlog (Current Work) board.Feb 17 2021, 12:27 AM

Etonkovidova closed this task as Resolved.Feb 18 2021, 1:53 AM

	F33988340: Screen Shot 2021-01-06 at 2.48.45 PM.png
	Jan 6 2021, 10:49 PM

[S] [wmf.25] MediaSearch: Audio mid files do not have audio iconsClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[S] [wmf.25] MediaSearch: Audio mid files do not have audio icons
Closed, ResolvedPublic
Actions