Maniphest T272038

Wikisource Extension: URL encode page title in sidebar links
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Jan 14 2021, 3:04 PM

Description

What is the problem?

Trying to use the sidebar links to export https://en.wikisource.org/wiki/The_Satires,_Epistles_%26_Art_of_Poetry_of_Horace returns: Page not found for: The_Satires,_Epistles_.

The link's href is https://wsexport.wmflabs.org/?format=epub-3&lang=en&page=The_Satires,_Epistles_&_Art_of_Poetry_of_Horace. The & should be %26.

I guess the same would go for other reserved characters.

Steps to reproduce problem

Go to https://en.wikisource.org/wiki/The_Satires,_Epistles_%26_Art_of_Poetry_of_Horace
In the left sidebar click "Download EPUB"

Expected behavior: Ebook downloads.
Observed behavior: Error message.

Environment

Wiki(s): Wikisource – (0c0e97a) 07:36, 11 January 2021.

Details

	Subject	Repo	Branch	Lines +/-
	URL encode page titles in WS Export links	mediawiki/extensions/Wikisource	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T256392: Wikisource Export: Migrate WSExport Gadget to Wikisource Extension
Mentioned Here: rEWSO7b6457dd9663: Merge "URL encode page titles in WS Export links"
rEWSO5c2b92bb6309: Localisation updates from https://translatewiki.net.
T256345: Wikisource Export: Make it possible to pre-fill the page title
rEWSO0c0e97a44123: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Jan 14 2021, 3:04 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2021, 3:04 PM

Samwilson claimed this task.Jan 15 2021, 12:12 AM

Samwilson edited projects, added Community-Tech (Kanban-2020-21-Q3); removed Community-Tech.

Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q3) board.

Samwilson set the point value for this task to 1.

Change 656279 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/extensions/Wikisource@master] URL encode page titles in WS Export links

https://gerrit.wikimedia.org/r/656279

gerritbot added a project: Patch-For-Review.Jan 15 2021, 12:26 AM

This is ready for review. I noticed also that the work for T256345 doesn't remove underscores from page names, so I'll fix that up.

The other thing that the sidebar links weren't including was the namespace. This is necessary for wikis that have other works namespaces such as 'Translate' etc. I've updated the above patch.

dom_walden mentioned this in T256392: Wikisource Export: Migrate WSExport Gadget to Wikisource Extension.Jan 15 2021, 4:09 PM

Change 656279 merged by jenkins-bot:
[mediawiki/extensions/Wikisource@master] URL encode page titles in WS Export links

https://gerrit.wikimedia.org/r/656279

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 18 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 18 2021, 6:10 PM

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Jan 18 2021, 6:11 PM

I can now use the sidebar links on https://en.wikisource.org/wiki/The_Satires,_Epistles_%26_Art_of_Poetry_of_Horace to correctly export.

As an extreme example, I can also use the links on https://en.wikisource.beta.wmflabs.org/wiki/Foo_!$%25%26%27()*%2B,/:;%3D%3F@_Bar.

Also, the links work for pages in non-Main namespaces (i.e. they include the correct namespace). I tested on the Author, Index, Page, Translation namespaces.

This change has gone to production.

Test Environments:

https://en.wikisource.beta.wmflabs.org Wikisource – (5c2b92b) 07:31, 22 January 2021
https://en.wikisource.org Wikisource – (7b6457d) 17:57, 18 January 2021

This is now on production, and I am no longer able to reproduce the bug. When I try to download the EPUB, it downloads as expected. For these reasons, O'm marking this ticket as Done.

Wikisource Extension: URL encode page title in sidebar linksClosed, ResolvedPublic1 Estimated Story PointsBUG REPORTActions