Page MenuHomePhabricator
Create Task
Maniphest T272844

Console warning in Firefox: Empty string passed to getElementById()
Closed, ResolvedPublic
Actions

Description

From document.getElementById(location.hash.slice(1))||[]

Example: https://sv.wikipedia.org/w/index.php?title=Anv%C3%A4ndare:Nirmos/common.js&oldid=48800646

Details

SubjectRepoBranchLines +/-
Avoid console warning when hash is emptymediawiki/extensions/SyntaxHighlight_GeSHimaster+4 -2
Customize query in gerrit

Related Objects

Event Timeline

Nirmos created this task.Jan 25 2021, 11:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2021, 11:53 AM
Esanders renamed this task from Empty string passed to getElementById() to Console warning in Firefox: Empty string passed to getElementById().Jan 25 2021, 10:28 PM
Esanders subscribed.

I assume you are talking about the console warning that appears in Firefox?

gerritbot added a comment.Jan 25 2021, 10:31 PM

Change 658448 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Avoid console warning when hash is empty

https://gerrit.wikimedia.org/r/658448

gerritbot added a project: Patch-For-Review.Jan 25 2021, 10:31 PM
gerritbot added a comment.Jan 25 2021, 10:54 PM

Change 658448 merged by jenkins-bot:
[mediawiki/extensions/SyntaxHighlight_GeSHi@master] Avoid console warning when hash is empty

https://gerrit.wikimedia.org/r/658448

Jdforrester-WMF closed this task as Resolved.Jan 25 2021, 10:57 PM
Jdforrester-WMF assigned this task to Esanders.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.28; 2021-01-26).Jan 25 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 25 2021, 11:10 PM
Krinkle mentioned this in T271572: Uncaught Error: Syntax error, unrecognized expression: #/search in at onHashChange.Feb 18 2021, 5:21 AM
Pols12 mentioned this in T315614: Comments highlighter causes “Empty string passed to getElementById()” when there is no anchor fragment in URL in Firefox.Aug 18 2022, 8:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits