Page MenuHomePhabricator

[S] Quickview: if we show license information, always show a license icon
Closed, ResolvedPublic

Description

The licensing information is shown without the copyright icon/label which might make it difficult for users to see that the licensing info is present:

Screen Shot 2021-01-13 at 3.17.24 PM.png (660×552 px, 323 KB)

Quickview currently shows icons for CC & PD licenses, but nothing for other licenses. In that case, it only prints the license text
This is inconsistent and might be a bit confusing and make it harder for users to identify the license text for what it is.

MultimediaViewer seems to use this fallback; I suspect we should simply use the same icon:

url("data:image/svg+xml,%3Csvg xmlns=%22http://www.w3.org/2000/svg%22 width=%2264%22 height=%2264%22 viewBox=%225.5 -3.5 64 64%22%3E %3Cpath fill=%22%2372777d%22 d=%22M13 .5v56h38.5C57.45 56.5 62 51.95 62 46V.5H13zM51.5 53H20V4h14v28l7-7 7 7V4h10.5v42c0 3.85-3.15 7-7 7z%22/%3E %3C/svg%3E")

Acceptance criteria:

  • figure out which icon matches the svg code above
  • find that icon in the WVUI icons file and copy/paste the data for that icon into the lib/icons.js file in the WBMI codebase
  • Add logic to the QuickView component to show this icon if none of the other license icons apply

Event Timeline

CBogen renamed this task from Quickview: if we show license information, always show a license icon to [S] Quickview: if we show license information, always show a license icon.Feb 9 2021, 5:44 PM

Change 674638 had a related patch set uploaded (by Seddon; owner: Seddon):
[mediawiki/extensions/WikibaseMediaInfo@master] Quickview: Always show a license icon for license

https://gerrit.wikimedia.org/r/674638

Change 674638 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Quickview: Always show a license icon for license

https://gerrit.wikimedia.org/r/674638

Etonkovidova added a subscriber: Etonkovidova.

Checked in commons wmf.37 - the licenses do have an image:

Screen Shot 2021-03-31 at 1.56.35 PM.png (642×1 px, 1 MB)

Change 704188 had a related patch set uploaded (by Seddon; author: Seddon):

[mediawiki/extensions/MediaSearch@master] Update assessment icon in quickview

https://gerrit.wikimedia.org/r/704188