Page MenuHomePhabricator

Deprecate WikiPage::hasViewableContent()
Open, Needs TriagePublic

Description

WikiPage represents the storage layer aspect of a page and its history. It shouldn't know about things like category pages showing category listings even when they don't exist as pages. That knowledge belongs to the "page type", and thus into Article (at least for now).

Article already has hasViewableContent(), but it'S deprecated in favor of WikiPage::hasViewableContent(). This should be reversed.

There are only a handful of callers, so this should be easy enough.

Event Timeline

Aklapper added a subscriber: Peter.ovchyn.

@Peter.ovchyn: Removing task assignee as this open task has been assigned for more than two years - See the email sent to task assignee on Feburary 22nd, 2023.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!