Maniphest T274957

WS Export: Fix errors with RTL languages
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Samwilson
	Feb 16 2021, 11:36 PM

Tags

Referenced Files

	F34108405: Screenshot_2021-02-17 יצוא מוויקיטקסט.png
	Feb 17 2021, 1:53 AM

Subscribers

Description

RTL languages should be displayed correctly.

e.g. https://ws-export.wmcloud.org/?uselang=he

Screenshot_2021-02-17 יצוא מוויקיטקסט.png (728×1 px, 53 KB)

Related Objects

Mentioned In: T273947: Add WS Export to translatewiki.net

Event Timeline

Samwilson created this task.Feb 16 2021, 11:36 PM

Restricted Application added a project: Community-Tech. · View Herald TranscriptFeb 16 2021, 11:36 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Samwilson updated the task description. (Show Details)Feb 17 2021, 1:53 AM

Samwilson set the point value for this task to 1.

Samwilson mentioned this in T273947: Add WS Export to translatewiki.net.

Samwilson edited projects, added Community-Tech (Kanban-2020-21-Q3); removed Community-Tech.

Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q3) board.

PR for review: https://github.com/wikimedia/ws-export/pull/332

Aklapper added a project: RTL.Feb 17 2021, 8:28 AM

Restricted Application added a project: I18n. · View Herald TranscriptFeb 17 2021, 8:28 AM

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q3) board.Feb 22 2021, 11:01 PM

The RTL version of the front page and statistics looks correct to me.

The version of the Bootstrap CSS library we are using does not support RTL, so we are using a third-party library which adds RTL support to Bootstrap. Later versions of Bootstrap apparently do support RTL, but I don't know if it is worth updating.

This change is now on production.

This change is now on production, and the RTL pages are properly displaying text in an RTL manner, as expected. If & when we decide to upgrade to a newer version of Bootstrap, we can look into RTL support changes (if any) at that time. I'm marking this as Done.