Page MenuHomePhabricator

Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect
Closed, ResolvedPublicBUG REPORT

Description

The UI of Protect Page form was recently changed in dewiki, probably due to task #T235424. Since then the "Seite beobachten" (Watch page) checkbox is not checked on opening the form leading to unwatch on protect.

Steps to Reproduce:

  1. As an admin open the Protect Page form on a page that you are watching.
  2. Protect the page without changing the "Seite beobachten" (Watch page) checkbox.

Actual Results:

  • After step 1 the "Seite beobachten" (Watch page) checkbox is not checked.
  • After step 2 the page becomes unwatched.

Expected Results:

  • After step 1 the "Seite beobachten" (Watch page) checkbox is checked reflecting that you are already watching the page.
  • After step 2 the page stays on the watchlist.

QA

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptWed, Feb 17, 9:21 AM
Count_Count renamed this task from On dewiki as an admin opening the Protect Page form leaves the Watch page checkbox unfilled leading to unwatch the page on protect to On dewiki as an admin opening the Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect.Wed, Feb 17, 9:22 AM
Count_Count updated the task description. (Show Details)Wed, Feb 17, 9:24 AM
hgzh added a subscriber: hgzh.Wed, Feb 17, 9:38 AM

The behaviour of the watch checkbox seems to be inverted. In addition to the effect mentioned by Count Count: if you try to protect a currently unwatched page, the 'watch page' checkbox is set by default.

Jdlrobson renamed this task from On dewiki as an admin opening the Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect to Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect.Wed, Feb 17, 4:45 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: BrandonXLF, Volker_E.

I can't seem to replicate this on German Wikipedia https://de.wikipedia.org/wiki/Niederkalmberg?action=protect&safemode=1 but I can replicate locally:

Digging into this some more.

Change 664920 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/664920

Toni_Mueller added a comment.EditedWed, Feb 17, 9:20 PM

Why did this change have to be made? This is a worsening of a good working function. The view was previously compact and clear. Now it's a lot bigger and clunkier. And the hooks are set wrongly in the exact opposite way.

@Toni_Mueller: Simplifying the user experience by standardizing the user interface across a lot of pages has been an ongoing effort for a while. See https://www.mediawiki.org/wiki/Wikimedia_User_Interface for general info and for places for general input on the design.
If you experience any specific software bugs, then please follow and https://www.mediawiki.org/wiki/How_to_report_a_bug report dedicated tickets. Thanks a lot.

Change 665173 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@wmf/1.36.0-wmf.30] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665173

Change 665174 had a related patch set uploaded (by Urbanecm; owner: Jdlrobson):
[mediawiki/core@wmf/1.36.0-wmf.31] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665174

Change 664920 merged by jenkins-bot:
[mediawiki/core@master] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/664920

Change 665173 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.30] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665173

Change 665174 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.31] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665174

Mentioned in SAL (#wikimedia-operations) [2021-02-19T01:02:06Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.31/includes/ProtectionForm.php: 2487c253b090d93daf85adae8ceb9d255cbf4ff2: field descriptors in HTMLForm must have keys (T275018; T274980) (duration: 01m 10s)

Mentioned in SAL (#wikimedia-operations) [2021-02-19T01:03:40Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.30/includes/ProtectionForm.php: d305308a5d46a3f86bf0b211e8a733c0a951ddc1: field descriptors in HTMLForm must have keys (T275018; T274980) (duration: 01m 08s)

Jdlrobson closed this task as Resolved.Fri, Feb 19, 1:04 AM
Jdlrobson claimed this task.

This should be fixed now. Please open a new ticket if any follow ups are needed.