Page MenuHomePhabricator
Create Task
Maniphest T274980

Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect
Closed, ResolvedPublicBUG REPORT
Actions

Description

The UI of Protect Page form was recently changed in dewiki, probably due to task #T235424. Since then the "Seite beobachten" (Watch page) checkbox is not checked on opening the form leading to unwatch on protect.

Steps to Reproduce:

  1. As an admin open the Protect Page form on a page that you are watching.
  2. Protect the page without changing the "Seite beobachten" (Watch page) checkbox.

Actual Results:

  • After step 1 the "Seite beobachten" (Watch page) checkbox is not checked.
  • After step 2 the page becomes unwatched.

Expected Results:

  • After step 1 the "Seite beobachten" (Watch page) checkbox is checked reflecting that you are already watching the page.
  • After step 2 the page stays on the watchlist.

QA

Details

SubjectRepoBranchLines +/-
field descriptors in HTMLForm must have keysmediawiki/coremaster+10 -10
field descriptors in HTMLForm must have keysmediawiki/corewmf/1.36.0-wmf.31+10 -10
field descriptors in HTMLForm must have keysmediawiki/corewmf/1.36.0-wmf.30+10 -10
Customize query in gerrit

Related Objects

Event Timeline

Count_Count created this task.Feb 17 2021, 9:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2021, 9:21 AM
Count_Count renamed this task from On dewiki as an admin opening the Protect Page form leaves the Watch page checkbox unfilled leading to unwatch the page on protect to On dewiki as an admin opening the Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect.Feb 17 2021, 9:22 AM
Count_Count updated the task description. (Show Details)Feb 17 2021, 9:24 AM
hgzh added a project: MediaWiki-Page-protection.Feb 17 2021, 9:26 AM
hgzh subscribed.Feb 17 2021, 9:38 AM

The behaviour of the watch checkbox seems to be inverted. In addition to the effect mentioned by Count Count: if you try to protect a currently unwatched page, the 'watch page' checkbox is set by default.

Aklapper mentioned this in T235424: Convert action=protect to OOUI (protect form is unusable on mobile).Feb 17 2021, 9:39 AM
Aklapper added a project: Regression.
XenonX3 subscribed.Feb 17 2021, 10:36 AM
Jdlrobson renamed this task from On dewiki as an admin opening the Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect to Protect Page form leaves the Watch page checkbox unfilled leading to unwatching the page on protect.Feb 17 2021, 4:45 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: BrandonXLF, Volker_E.
Jdlrobson subscribed.Feb 17 2021, 8:28 PM

I can't seem to replicate this on German Wikipedia https://de.wikipedia.org/wiki/Niederkalmberg?action=protect&safemode=1 but I can replicate locally:

Screen Shot 2021-02-17 at 12.22.19 PM.png (688×1 px, 78 KB)

Digging into this some more.

Jdlrobson added a project: OOUI.Feb 17 2021, 8:34 PM
Toni_Mueller subscribed.Feb 17 2021, 9:15 PM
gerritbot added a comment.Feb 17 2021, 9:17 PM

Change 664920 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/664920

gerritbot added a project: Patch-For-Review.Feb 17 2021, 9:17 PM
Toni_Mueller added a comment.EditedFeb 17 2021, 9:20 PM

Why did this change have to be made? This is a worsening of a good working function. The view was previously compact and clear. Now it's a lot bigger and clunkier. And the hooks are set wrongly in the exact opposite way.

Jdlrobson mentioned this in T231291: AMC mode: No link to delete or move, protect and other admin and non-admin actions in Minerva.Feb 17 2021, 10:13 PM
Aklapper added a comment.Feb 17 2021, 11:01 PM

@Toni_Mueller: Simplifying the user experience by standardizing the user interface across a lot of pages has been an ongoing effort for a while. See https://www.mediawiki.org/wiki/Wikimedia_User_Interface for general info and for places for general input on the design.
If you experience any specific software bugs, then please follow and https://www.mediawiki.org/wiki/How_to_report_a_bug report dedicated tickets. Thanks a lot.

gerritbot added a comment.Feb 19 2021, 12:23 AM

Change 665173 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@wmf/1.36.0-wmf.30] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665173

gerritbot added a comment.Feb 19 2021, 12:24 AM

Change 665174 had a related patch set uploaded (by Urbanecm; owner: Jdlrobson):
[mediawiki/core@wmf/1.36.0-wmf.31] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665174

gerritbot added a comment.Feb 19 2021, 12:52 AM

Change 664920 merged by jenkins-bot:
[mediawiki/core@master] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/664920

gerritbot added a comment.Feb 19 2021, 12:56 AM

Change 665173 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.30] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665173

gerritbot added a comment.Feb 19 2021, 12:56 AM

Change 665174 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.31] field descriptors in HTMLForm must have keys

https://gerrit.wikimedia.org/r/665174

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 19 2021, 1:00 AM
Stashbot mentioned this in T275018: Prefilling the protection form does not work as expected.Feb 19 2021, 1:02 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-19T01:02:06Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.31/includes/ProtectionForm.php: rMW2487c253b090: field descriptors in HTMLForm must have keys (T275018; T274980) (duration: 01m 10s)

Stashbot added a comment.Feb 19 2021, 1:03 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-19T01:03:40Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.30/includes/ProtectionForm.php: rMWd305308a5d46: field descriptors in HTMLForm must have keys (T275018; T274980) (duration: 01m 08s)

Jdlrobson closed this task as Resolved.Feb 19 2021, 1:04 AM
Jdlrobson claimed this task.

This should be fixed now. Please open a new ticket if any follow ups are needed.

Maintenance_bot removed a project: Patch-For-Review.Feb 19 2021, 1:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits