Page MenuHomePhabricator
Create Task
Maniphest T275798

Fatal exception of type "Error" after Special:AbuseFilter/test submit
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

normalized_message
[YDfYKVHPfO8owc0sdU7T2AAAAMQ] /wiki/Special:AbuseFilter/test   Error: Class 'StructuredDiscussions\Hooks\AbuseFilterHandler' not found
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.32/vendor/wikimedia/object-factory/src/ObjectFactory.php(244)
#0 /srv/mediawiki/php-1.36.0-wmf.32/vendor/wikimedia/object-factory/src/ObjectFactory.php(150): Wikimedia\ObjectFactory::getObjectFromSpec(array, array)
#1 /srv/mediawiki/php-1.36.0-wmf.32/includes/HookContainer/HookContainer.php(468): Wikimedia\ObjectFactory->createObject(array)
#2 /srv/mediawiki/php-1.36.0-wmf.32/includes/HookContainer/HookContainer.php(159): MediaWiki\HookContainer\HookContainer->getHandlers(string, array)
#3 /srv/mediawiki/php-1.36.0-wmf.32/extensions/AbuseFilter/includes/Hooks/AbuseFilterHookRunner.php(173): MediaWiki\HookContainer\HookContainer->run(string, array)
#4 /srv/mediawiki/php-1.36.0-wmf.32/extensions/AbuseFilter/includes/VariableGenerator/RCVariableGenerator.php(85): MediaWiki\Extension\AbuseFilter\Hooks\AbuseFilterHookRunner->onAbuseFilterGenerateVarsForRecentChange(MediaWiki\Extension\AbuseFilter\VariableGenerator\RCVariableGenerator, RecentChange, MediaWiki\Extension\AbuseFilter\Variables\VariableHolder, User)
#5 /srv/mediawiki/php-1.36.0-wmf.32/extensions/AbuseFilter/includes/View/AbuseFilterViewTestBatch.php(309): MediaWiki\Extension\AbuseFilter\VariableGenerator\RCVariableGenerator->getVars()
#6 /srv/mediawiki/php-1.36.0-wmf.32/extensions/AbuseFilter/includes/View/AbuseFilterViewTestBatch.php(210): MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewTestBatch->doTest()
#7 /srv/mediawiki/php-1.36.0-wmf.32/extensions/AbuseFilter/includes/Special/SpecialAbuseFilter.php(162): MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewTestBatch->show()
#8 /srv/mediawiki/php-1.36.0-wmf.32/includes/specialpage/SpecialPage.php(645): MediaWiki\Extension\AbuseFilter\Special\SpecialAbuseFilter->execute(string)
#9 /srv/mediawiki/php-1.36.0-wmf.32/includes/specialpage/SpecialPageFactory.php(1405): SpecialPage->run(string)
#10 /srv/mediawiki/php-1.36.0-wmf.32/includes/MediaWiki.php(310): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#11 /srv/mediawiki/php-1.36.0-wmf.32/includes/MediaWiki.php(944): MediaWiki->performRequest()
#12 /srv/mediawiki/php-1.36.0-wmf.32/includes/MediaWiki.php(548): MediaWiki->main()
#13 /srv/mediawiki/php-1.36.0-wmf.32/index.php(53): MediaWiki->run()
#14 /srv/mediawiki/php-1.36.0-wmf.32/index.php(46): wfIndexMain()
#15 /srv/mediawiki/w/index.php(3): require(string)
#16 {main}
Impact

Cannot test filters under some specific circumstances. I suspect this is because of Flow integration (T115128).

Notes

Can be reproduced on Wikidata. Inputs:

  • conditions: 1==1
  • user: VIGNERON
  • after: 20210225140000
  • before: 20210225150000

Details

Request ID
YDfYKVHPfO8owc0sdU7T2AAAAMQ
Request URL
https://www.wikidata.org/wiki/Special:AbuseFilter/test
SubjectRepoBranchLines +/-
Fix hook namemediawiki/extensions/AbuseFiltermaster+2 -2
Fix namespace in AbuseFilter hook handlermediawiki/extensions/Flowmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

matej_suchanek created this task.Feb 25 2021, 5:19 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 25 2021, 5:19 PM
Daimona updated the task description. (Show Details)Feb 25 2021, 6:31 PM

It is indeed due to flow integration... Looks like a silly error though. Should be an easy fix.

gerritbot added a comment.Feb 25 2021, 6:34 PM

Change 666973 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/Flow@master] Fix namespace in AbuseFilter hook handler

https://gerrit.wikimedia.org/r/666973

gerritbot added a project: Patch-For-Review.Feb 25 2021, 6:34 PM
Daimona claimed this task.Feb 25 2021, 6:35 PM
gerritbot added a comment.Feb 25 2021, 7:43 PM

Change 666973 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Fix namespace in AbuseFilter hook handler

https://gerrit.wikimedia.org/r/666973

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Feb 25 2021, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 25 2021, 8:10 PM
Umherirrender closed this task as Resolved.Mar 2 2021, 8:14 PM
matej_suchanek reopened this task as Open.EditedMar 6 2021, 2:55 PM
matej_suchanek removed Daimona as the assignee of this task.

Still getting an exception for the same query, although the fix is already in prod:
[YEOXDU@rKc0oxE97ffWbOAAAANU] 2021-03-06 14:51:57: Fatal exception of type „Error“

Umherirrender subscribed.Mar 6 2021, 3:05 PM

That sounds like another issue within the same special page. Needs a stack trace to look further.

Daimona added a comment.Mar 6 2021, 4:10 PM
Error: Call to undefined method MediaWiki\Extension\StructuredDiscussions\Hooks\AbuseFilterHandler::onAbuseFilter_generateVarsForRecentChange()
from /srv/mediawiki/php-1.36.0-wmf.33/includes/HookContainer/HookContainer.php(163)
#0 /srv/mediawiki/php-1.36.0-wmf.33/extensions/AbuseFilter/includes/Hooks/AbuseFilterHookRunner.php(173): MediaWiki\HookContainer\HookContainer->run(string, array)
#1 /srv/mediawiki/php-1.36.0-wmf.33/extensions/AbuseFilter/includes/VariableGenerator/RCVariableGenerator.php(85): MediaWiki\Extension\AbuseFilter\Hooks\AbuseFilterHookRunner->onAbuseFilterGenerateVarsForRecentChange(MediaWiki\Extension\AbuseFilter\VariableGenerator\RCVariableGenerator, RecentChange, MediaWiki\Extension\AbuseFilter\Variables\VariableHolder, User)
#2 /srv/mediawiki/php-1.36.0-wmf.33/extensions/AbuseFilter/includes/View/AbuseFilterViewTestBatch.php(309): MediaWiki\Extension\AbuseFilter\VariableGenerator\RCVariableGenerator->getVars()
#3 /srv/mediawiki/php-1.36.0-wmf.33/extensions/AbuseFilter/includes/View/AbuseFilterViewTestBatch.php(210): MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewTestBatch->doTest()
#4 /srv/mediawiki/php-1.36.0-wmf.33/extensions/AbuseFilter/includes/Special/SpecialAbuseFilter.php(162): MediaWiki\Extension\AbuseFilter\View\AbuseFilterViewTestBatch->show()
#5 /srv/mediawiki/php-1.36.0-wmf.33/includes/specialpage/SpecialPage.php(645): MediaWiki\Extension\AbuseFilter\Special\SpecialAbuseFilter->execute(string)
#6 /srv/mediawiki/php-1.36.0-wmf.33/includes/specialpage/SpecialPageFactory.php(1383): SpecialPage->run(string)
#7 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(309): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#8 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(925): MediaWiki->performRequest()
#9 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(547): MediaWiki->main()
#10 /srv/mediawiki/php-1.36.0-wmf.33/index.php(53): MediaWiki->run()
#11 /srv/mediawiki/php-1.36.0-wmf.33/index.php(46): wfIndexMain()
#12 /srv/mediawiki/w/index.php(3): require(string)
#13 {main}
gerritbot added a comment.Mar 6 2021, 4:13 PM

Change 669091 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] Fix hook name

https://gerrit.wikimedia.org/r/669091

gerritbot added a project: Patch-For-Review.Mar 6 2021, 4:13 PM
Daimona claimed this task.Mar 6 2021, 4:13 PM
gerritbot added a comment.Mar 8 2021, 6:09 PM

Change 669091 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Fix hook name

https://gerrit.wikimedia.org/r/669091

Maintenance_bot removed a project: Patch-For-Review.Mar 8 2021, 6:10 PM
Daimona closed this task as Resolved.Mar 8 2021, 6:15 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.34; 2021-03-09); removed MW-1.36-notes (1.36.0-wmf.33; 2021-03-02).Mar 8 2021, 7:00 PM
Krinkle moved this task from Untriaged to Feb 2021 on the Wikimedia-production-error board.Jul 29 2022, 11:16 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL