Page MenuHomePhabricator

AbuseFilter test tools does not work for Flow edits
Open, HighPublic

Description

Try checking on a Flow edit here. https://www.mediawiki.org/wiki/Special:AbuseFilter/test

Actual: Doesn't appear.
Expected: It should work the same way it does for wikitext edits.

Event Timeline

Glaisher created this task.Oct 9 2015, 4:59 PM
Glaisher updated the task description. (Show Details)
Glaisher raised the priority of this task from to Needs Triage.
Glaisher added a subscriber: Glaisher.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptOct 9 2015, 4:59 PM
Restricted Application added subscribers: Luke081515, Aklapper. · View Herald Transcript
Glaisher renamed this task from AbuseFilter examine/test tools does not work for Flow edits to AbuseFilter test tools does not work for Flow edits.Oct 27 2015, 3:47 PM
Glaisher set Security to None.

Sorry, actually examine does work, it's test interface which is not working properly. See T116744#1757682.

In T115128#1757736, @Mattflaschen wrote:

Could you explain how you got to https://www.mediawiki.org/wiki/Special:AbuseFilter/examine/log/82309, just for my knowledge?

Through https://www.mediawiki.org/wiki/Special:AbuseLog examine links.

Luke081515 triaged this task as High priority.Dec 9 2015, 8:41 AM
He7d3r added a subscriber: He7d3r.Nov 16 2016, 11:16 AM

In rEABF32e2a7c27e9b0f5dba0328287434a0a3a5331e48, I tried to generalize how recentchanges are used in both interfaces for testing. Introducing some hook could do the trick (not sure if it would be enough, though).

Framawiki added a subscriber: Framawiki.

Change 445323 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/extensions/AbuseFilter@master] [WIP] Make Flow edits testable

https://gerrit.wikimedia.org/r/445323

Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 11 2018, 11:34 PM
Restricted Application added a subscriber: Daimona. · View Herald Transcript

The patch above only needs Flow to properly format our entry in /test (and maybe some adjustments for /examine). However, not only I don't know Flow code at all, but I'm also having big problems in making Flow work on my wiki.
I determined that Flow entries aren't shown because the onOldChangesListRecentChangesLine hook returns false. This happens for two reasons: first, here the change is excluded from the view. Second, it doesn't exists in this cache. I'm not really sure about what we should do: maybe change the RC entry on AbuseFilter? Or maybe add specific methods to Flow to handle entries in Special:AbuseFilter/test? I'd appreciate it if someone from Flow would give it a look!

This issue is preventing my abusefilter at MediaWiki (https://www.mediawiki.org/wiki/Special:AbuseFilter/59) from working properly. It'll be very nice if this issue could be fixed as soon as possible.

@Leaderboard Let's wait for someone who knows well Flow's code. Since I don't, I want to avoid to destroy everything :-) Also, we currently have several other bugs which require higher attention.

Leaderboard raised the priority of this task from High to Unbreak Now!.Jan 16 2019, 10:40 AM

It won't be wrong to say that this bug is the major reason for all of the spam on MediaWiki, and hence this should be urgently fixed.
All of the spam now comes from flow talk pages.

Restricted Application added subscribers: Liuxinyu970226, TerraCodes. · View Herald TranscriptJan 16 2019, 10:40 AM
Daimona lowered the priority of this task from Unbreak Now! to High.Jan 16 2019, 10:58 AM

@Leaderboard IMHO this isn't UBN! per https://www.mediawiki.org/wiki/Phabricator/Project_management#Priority_levels. Again, the patch above (which I'm going to rebase) is WIP because something in Flow codebase prevents it from working, and I don't want to mess with it. I also had several troubles in getting Flow to work properly on my wiki, and thus testing the patch. Developers/Maintainers says stewards are Growth-Team, and this task is already on their workboard. We should get someone from there to give a look to the patch.
This is also not UBN because filters still work -even though they cannot be tested-, and being myself a sysop on MediaWiki I can try to help tuning spam-related filters, I just need some time and examples.

@Daimona I'm sorry, but the filters don't work, at least filter 59 (flow variant of the hugely useful filter 12) doesn't.

@Leaderboard May I please have some spam examples which should have triggered filter 59?

@Leaderboard Thanks, I'm working on it (i.e. on understanding why filter 59 didn't trigger), while for testing flow edits we still need someone who knows Flow's codebase.

Daimona moved this task from Backlog to Waiting on the User-Daimona board.