Page MenuHomePhabricator

Remove PrefetchingTermLookup from WikibaseServices
Closed, ResolvedPublic

Description

Depends on T277304: Move WikibaseClient PrefetchingTermLookup to service container and T280643: Remove TermSearchInteractorFactory from WikibaseServices/SingleEntitySourceServices

AC

Method removed from

  • WikibaseServices Interface
  • MultipleEntitySourceServices
  • SingleEntitySourceServices

Event Timeline

In fact, this cannot yet be picked up, until we remove TermSearchInteractorFactory from Wikibase Services, as getPrefetchingTermLookup, is used in that method on SingleEntitySourceServices.

And as for TermSearchInteractorFactory, it’s worth noting that WikibaseClient has a method

	/**
	 * XXX: This is not used by client itself, but is used by ArticlePlaceholder!
	 */
	public function newTermSearchInteractor( string $displayLanguageCode ): TermSearchInteractor {
		return self::getWikibaseServices()->getTermSearchInteractorFactory()
			->newInteractor( $displayLanguageCode );
	}

but ArticlePlaceholder hasn’t actually used this method since March 2020 (removed in rEARP3c9ae982ece3: Drop legacy database search integration code). So as far as I can tell, we can remove the WikibaseClient use of that service directly.

The WikibaseClient method is gone, so now the TermSearchInteractorFactory is only used in WikibaseRepo.

Change 683664 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Remove getTermBuffer from DataAccessServices

https://gerrit.wikimedia.org/r/683664

Change 683665 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Remove PrefetchingTermLookup from WikibaseServices

https://gerrit.wikimedia.org/r/683665

Change 683664 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove getTermBuffer from DataAccessServices

https://gerrit.wikimedia.org/r/683664

Change 683665 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove PrefetchingTermLookup from WikibaseServices

https://gerrit.wikimedia.org/r/683665