Page MenuHomePhabricator
Create Task
Maniphest T280643

Remove TermSearchInteractorFactory from WikibaseServices/SingleEntitySourceServices
Closed, ResolvedPublic
Actions

Description

We need to remove TermSearchInteractorFactory from SingleEntitySourceServices. This should then allow us to first remove PrefetchingTermLookup from WikibaseServices (T277856), and finally stop passing and instance of SingleEntitySourceServices into the PrefetchingTermLookup callbacks (T277858).

TermSearchInteractorFactory can probably be moved directly to the service container.

Details

SubjectRepoBranchLines +/-
WikibaseRepo: Move TermSearchInteractorFactory to service containermediawiki/extensions/Wikibasemaster+87 -108
WikibaseRepo: Create a MatchingTermsLookupFactory servicemediawiki/extensions/Wikibasemaster+256 -0
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Apr 20 2021, 9:54 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 20 2021, 9:54 AM
Addshore added a project: [DEPRECATED] wdwb-tech.Apr 20 2021, 9:59 AM
Addshore moved this task from Inbox to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.Apr 20 2021, 11:05 AM
Addshore added a project: Wikidata-Campsite.Apr 20 2021, 11:13 AM
Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.
ItamarWMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Apr 22 2021, 10:11 AM
Rosalie_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.Apr 22 2021, 4:03 PM
Rosalie_WMDE claimed this task.Apr 22 2021, 5:06 PM
Addshore moved this task from Triaged Low (0-50) to Active on the [DEPRECATED] wdwb-tech board.Apr 23 2021, 10:45 AM
Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Apr 26 2021, 6:25 AM
Rosalie_WMDE moved this task from Doing to Ready to pick up on the Wikibase Service Migration board.
Rosalie_WMDE subscribed.
Addshore moved this task from Active to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.Apr 26 2021, 8:19 AM
ItamarWMDE claimed this task.Apr 27 2021, 9:45 AM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 27 2021, 5:19 PM

Change 683006 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] WikibaseRepo: Create a MatchingTermsLookupFactory service

https://gerrit.wikimedia.org/r/683006

gerritbot added a project: Patch-For-Review.Apr 27 2021, 5:19 PM

Change 683007 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] WikibaseRepo: Move TermSearchInteractorFactory to service container

https://gerrit.wikimedia.org/r/683007

ItamarWMDE added a comment.EditedApr 28 2021, 9:14 AM

After further investigation, it seems that migrating TermInLangIdsResolver is not enough in order to be able to remove SingleEntitySourceServiceFactory but also SingleEntitySourceServices::getEntityRevisionLookup needs to be migrated too somehow. As this task seems to be too big to achieve at this moment, I will be breaking it down to two more tasks:

  1. Migrate TermsInLangIdsResolver
  2. Migrate EntityRevisionLookp fropm Multiple/SingleEntitySourceServices (DataAccess Services)

I will set these tasks as children of T277731: WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServicesFactory Service and rephrase that task to include the client version of that service as well.

ItamarWMDE renamed this task from Remove TermSearchInteractorFactory and TermInLangIdsResolver from WikibaseServices/SingleEntitySourceServices to Remove TermSearchInteractorFactory from WikibaseServices/SingleEntitySourceServices.Apr 28 2021, 10:13 AM
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE mentioned this in T277856: Remove PrefetchingTermLookup from WikibaseServices.Apr 28 2021, 10:16 AM
ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 28 2021, 10:46 AM
gerritbot added a comment.Apr 29 2021, 12:11 PM

Change 683006 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] WikibaseRepo: Create a MatchingTermsLookupFactory service

https://gerrit.wikimedia.org/r/683006

gerritbot added a comment.Apr 29 2021, 12:14 PM

Change 683007 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] WikibaseRepo: Move TermSearchInteractorFactory to service container

https://gerrit.wikimedia.org/r/683007

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 29 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 29 2021, 1:10 PM
ItamarWMDE closed this task as Resolved.Apr 29 2021, 1:46 PM
ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE mentioned this in T331903: Remove DataAccessServices, WikibaseServices, MultipleEntitySourceServices.Mar 13 2023, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits